Add new logging docs #2254
Merged
Add new logging docs #2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
reviewed
Oct 24, 2019
SydneyhSmith
approved these changes
Oct 24, 2019
| @@ -185,6 +180,30 @@ Logs provide context for what was happening when the issue occurred. | |||
| vscode-powershell@microsoft.com. Please still open an issue though | |||
| so we can track the work — other users may have the same issue. | |||
|
|
|||
| #### Provide Language Server Protocol payload logs | |||
|
|
|||
There was a problem hiding this comment.
Should we specify that this only applies to certain versions of the extension i.e. if you have 2019-10 or above?
No we will still use that as the first attempt to diagnose the problem. That gives us: vscode-powershell logs |
Co-Authored-By: Robert Holt <rjmholt@gmail.com>
rjmholt
approved these changes
Oct 25, 2019
|
We can wait to merge this until the release. Just to be safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add new section on getting the payloads of the messages. Keep in mind, the "old way" is still needed as it will still give us:
vscode-powershell logs
Start up logs (from Start-EditorServices.ps1)
PSES logs (without the payloads)
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready