Skip to content

Add scripts for VSTS to pick PSES branches to include #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Aug 27, 2018

PR Summary

Adds scripts to be used by the build to determine what PSES branch to build against.

This means a given branch of the VSCode extension can set the PSES_BRANCH environment variable in tools/releaseBuild/setVstsVariables.ps1 to determine what branch of EditorServices will get pulled into that build.

Quick design consideration: should this instead be expanded out to a JSON or a PSD1 file?

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@rjmholt rjmholt requested a review from TylerLeonhardt August 27, 2018 00:47
@@ -0,0 +1,11 @@
$vstsVariables = @{
PSES_BRANCH = '2.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this set to 2.0.0 vs 1.8.X?

Copy link
Contributor Author

@rjmholt rjmholt Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I cherry picked this change from a branch building against 2.0.0. Have changed it to master

@rjmholt rjmholt force-pushed the add-branch-release-tooling branch from 3b59e62 to e3283f7 Compare August 27, 2018 22:40
@rjmholt rjmholt merged commit c3850d6 into PowerShell:master Aug 31, 2018
@rjmholt rjmholt deleted the add-branch-release-tooling branch December 12, 2018 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants