Skip to content

Restore ability to start debug session when script run in PSIC hits bkpt #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

rkeithhill
Copy link
Contributor

Fix #956

PR Summary

Restores some code that I took out in PR #1062 when VSCode removed a debug API we were using and
switched to a debug config provider model. So sorry guys, this one was my bad.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@rkeithhill rkeithhill requested a review from TylerLeonhardt July 8, 2018 20:34
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rkeithhill rkeithhill closed this Jul 10, 2018
@rkeithhill rkeithhill reopened this Jul 10, 2018
@rkeithhill rkeithhill merged commit 777f7b1 into master Jul 10, 2018
@rkeithhill rkeithhill deleted the rkeithhill/start-debug-session-from-psic branch July 10, 2018 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger not started when breakpoint is set in the editor
2 participants