onDebug to onDebugResolve:type

[TylerLeonhardt]

The docs say, in 1.19, VSCode made more fine-grained debugger activation events.

Read the link for the full details but the rule of thumb goes as followed:

Rule of thumb: If activation of a debug extensions is lightweight, use onDebug. If it is heavyweight, use onDebugInitialConfigurations and/or onDebugResolve depending on whether the DebugConfigurationProvider implements the corresponding methods provideDebugConfigurations and/or resolveDebugConfiguration.

The vscode-powershell extension implements just resolveDebugConfiguration here so we just need to replace onDebug with onDebugResolve:type

Resolves #1179

[TylerLeonhardt]

@roblourens for the FYI (would also love your 👍 if you don't mind)

[rkeithhill]

That's all it takes? Cool.

[TylerLeonhardt]

I looked through the docs, changed this and debugging still worked so this looks right.

[TylerLeonhardt]

Oh I need to update the engine version

[rkeithhill]

LGTM

[TylerLeonhardt]

For reference: https://github.com/Microsoft/vscode-java-debug/pull/196/files

[rkeithhill]

In the past, @daviwil has tried to support both the current version of VSCode and n-1 IIRC. This would deviate from the policy unless the VSCode team release 1.20 before we release 1.6.0. :-)

[roblourens]

LGTM, thanks! 1.20 will be released sometime in the middle of next week.

[TylerLeonhardt]

I'll keep this open until 1.20 is released since it's such a small change.

[TylerLeonhardt]

1.20 was released a couple days ago! I'm going to merge this in now :)