powershellExePath setting not accepting full path with env var

[rkeithhill]

System Details

• Operating system name and version: Windows 10 CU
• VS Code version: 1.13.1
• PowerShell extension version: 1.4.1
• Output from $PSVersionTable: 5.1.15063.447

Issue Description

I've set the powershellExePath setting to run a local build using a full path that uses a vscode env var and the extension appears to be trying to use that as a relative path:

powershell.exe cannot be found or is not accessible at path C:\Users\Keith\.vscode\extensions\ms-vscode.powershell-1.4.1\out\${env:USERPROFILE}\GitHub\rkeithhill\PowerShell\src\powershell-win-core\bin\Debug\netcoreapp2.0\win10-x64\publish\powershell.exe

Note it works fine if I don't use the ${env:xx} syntax. So not a huge problem but it would be nice if it did support env vars. :-)

[JustinGrote]

While this is not supported in vscode settings files as-is (tracking issue: microsoft/vscode#2809), I don't see a reason why the module couldn't take the setting input and interpret it.

This makes more sense now that things like settings sync are now available, so that if I have PWSH in my users folder consistently I can use ${env:USERPROFILE} or something to reference it rather than having to customize it for each system I run code on.

@SydneyhSmith this should be reclassified as an enhancement.