Unable to Load Terminal

[CATgwalker]

Issue Type: Bug

After recent update to 2021.5.1, the terminal fails to load with below error on Windows Server 2016 with WMF 5.1

Extension version: 2021.5.1
VS Code version: Code 1.56.2 (054a9295330880ed74ceaedda236253b4f39a335, 2021-05-12T17:13:13.157Z)
OS version: Windows_NT x64 10.0.14393

[andyleejordan]

What version of PowerShell are you using? @rjmholt we should take a look at this.

[CATgwalker]

Name                           Value
----                           -----
PSVersion                      5.1.14393.4402
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.4402
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

[andyleejordan]

Interesting...can you tell me if it repros with PowerShell 7? Just to help narrow down the cause.

Also, could you please provide your logs by following these steps?

[CATgwalker]

I am not able to install PowerShell 7 on this server - it is an Azure Automation hybrid worker and only works with PS 5.1.

1622738848-33b3fe3f-9d15-4d9e-95f6-08cd39cb8ff81622738843439.zip

[andyleejordan]

That is helpful, thanks!

@rjmholt curiously I see this:

Could not load file or assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'

Why on earth is netstandard trying to be loaded for PowerShell 5.1? This PowerShell/PowerShellEditorServices#1426 is the only related change I can think of, but it doesn't appear like it'd cause this.

[andyleejordan]

Could this have something to do with it @rjmholt:

2 The versions listed here represent the rules that NuGet uses to determine whether a given .NET Standard library is applicable. While NuGet considers .NET Framework 4.6.1 as supporting .NET Standard 1.5 through 2.0, there are several issues with consuming .NET Standard libraries that were built for those versions from .NET Framework 4.6.1 projects. For .NET Framework projects that need to use such libraries, we recommend that you upgrade the project to target .NET Framework 4.7.2 or higher.

From https://docs.microsoft.com/en-us/dotnet/standard/net-standard

[andyleejordan]

Well, that's a bug. @rjmholt I can confirm that netstandard.dll is not contained in PowerShell-2021.5.1, but I have no idea why:

$ find PowerShell-2021.2.2 -name netstandard.dll
PowerShell-2021.2.2/extension/modules/PowerShellEditorServices/bin/Desktop/netstandard.dll
@JEWANG3 ~/Downloads 
$ find PowerShell-2021.5.1 -name netstandard.dll
@JEWANG3 ~/Downloads 
$ 
$ ls PowerShell-2021.5.1/extension/modules/PowerShellEditorServices/bin/Desktop/
Microsoft.PowerShell.EditorServices.Hosting.dll  System.Runtime.InteropServices.RuntimeInformation.dll
Microsoft.PowerShell.EditorServices.Hosting.pdb  System.ValueTuple.dll

[andyleejordan]

Ok so I can reproduce this in the build and have a good commit at v2.3.0, and a bad commit at v2.4.0-preview.1, but only if I delete the whole .dotnet folder and run our SetupDotnet task (in addition to cleaning and building). In former, we were only installing up to .NET SDK 5.0, in the latter we now install .NET SDK 6.0 (to support PowerShell 7.2). The behavior of dotnet publish appears to have changed because with the former version, netstandard.dll is included upon publishing, and with the latter it is not.