Add MRU to argument prompt when debugging a PowerShell script

[sba923]

Summary of the new feature

When one debugs a PowerShell script with the "PowerShell Launch Current File w/Args Prompt" configuration:

        {
            "type": "PowerShell",
            "request": "launch",
            "name": "PowerShell Launch Current File w/Args Prompt",
            "script": "${file}",
            "args": [
                "${command:SpecifyScriptArgs}"
            ],
            "cwd": "${file}"
        },

the input field is pre-filled with the most recent arguments input on the previous debug session.

It would be useful to have a list of most recently used argument lists, so that one could easily test the same script with several sets of arguments.

Proposed technical implementation details (optional)

The list should be sorted by most-recently used argument list.

[sba923]

I realize this change probably needs to be done in VScode itself, not in the extension. Correct?

[rkeithhill]

IIRC that UI and last input feature is provided by VSCode and not the extension. You might want to raise this issue in the https://github.com/microsoft/vscode project.

[sba923]

IIRC that UI and last input feature is provided by VSCode and not the extension. You might want to raise this issue in the https://github.com/microsoft/vscode project.

I'm on my way... but who actually implements SpecifyScriptArgs?

[TylerLeonhardt]

@rkeithhill we implement SpecifyScriptArgs:

https://github.com/TylerLeonhardt/vscode-powershell/blob/c23cc9d980dd7b199d350824e560320055e4e1e6/src/features/DebugSession.ts#L339-L370

[rkeithhill]

Sigh, sad thing is that I implemented that feature 2 years ago according to Git. 🤷‍♂️

[sba923]

So? Back to square one... The VScode guys have closed the issues there 'cos it's extension related... 😝

[rjmholt]

Back to square one...

No no, we have the feature request here now and we've recognised we own the code for it

[rkeithhill]

We use VSCode's showInputBox() method which allows you to enter arbitrary text but AFAICT it doesn't support any sort of dropdown with canned input. Then there's showQuickPick which shows a dropdown list of items to pick from but does not allow for arbitrary text entry. Is there a "dropdown combo" input box that I'm missing in the API?

FWIW if I could find the appropriate VSCode API for this style of input control, the implementation would likely be very simple.

[rkeithhill]

The way I see VSCode handle this today is to first pop a quickPick box:

Which includes an item to specify a new value e.g. + Create new branch... which when clicked pops an inputBox:

If that is the only way to implement this then I would not be in favor of doing so as it makes the common case harder.

That said, I can't believe VSCode doesn't provide the equivalent of a Combobox