Microsoft.Extensions.DependencyInjection.Abstractions.dll already loaded due to Omnisharp dependencies

[bgelens]

I'm running 2019.11.1 (the out of band fix for the @ problem #2274 ) and cannot import Az.Resources anymore as a dll is already loaded. It still imports fine outside of the integrated terminal so I'm curious if something changed in this release that might cause this?

PSVersion

Name                           Value
----                           -----
PSVersion                      7.0.0-preview.5
PSEdition                      Core
GitCommitId                    7.0.0-preview.5
OS                             Darwin 19.0.0 Darwin Kernel Version 19.0.0: Thu Oct 17 16:17:15 PDT 2019; root:xnu-6153.41.3~29/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Loaded Modules:

ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Manifest   7.0.0.0               Microsoft.PowerShell.Management     {Add-Content, Clear-Content, Clear-Item, Clear-ItemProperty…}
Manifest   7.0.0.0               Microsoft.PowerShell.Security       {ConvertFrom-SecureString, ConvertTo-SecureString, Get-Credential, Get-ExecutionPolicy…}
Manifest   7.0.0.0               Microsoft.PowerShell.Utility        {Add-Member, Add-Type, Clear-Variable, Compare-Object…}
Script     2.0.325               oh-my-posh                          {Get-ComputerName, Get-Drive, Get-FullPath, Get-ShortPath…}
Script     0.7.3                 posh-git                            {Add-PoshGitToProfile, Add-SshKey, Enable-GitColors, Expand-GitCommand…}
Script     0.2.0                 PowerShellEditorServices.Commands   {ConvertFrom-ScriptExtent, ConvertTo-ScriptExtent, Find-Ast, Get-Token…}
Binary     0.2.0                 PowerShellEditorServices.VSCode     {Close-VSCodeHtmlContentView, New-VSCodeHtmlContentView, Set-VSCodeHtmlContentView, Show-VSCodeHtmlContentView…}
Script     2.0.0      beta5      PSReadLine                          {Get-PSReadLineKeyHandler, Get-PSReadLineOption, Remove-PSReadLineKeyHandler, Set-PSReadLineKeyHandler…}

Trying to load Az.Resources

�[1;32mException             : �[0m
    �[1;32mMessage    : �[0mAssembly with same name is already loaded
    �[1;32mTargetSite : �[0m
        �[1;32mName          : �[0mBind_LoadAssemblies
        �[1;32mDeclaringType : �[0mSystem.Management.Automation.Runspaces.InitialSessionState
        �[1;32mMemberType    : �[0mMethod
        �[1;32mModule        : �[0mSystem.Management.Automation.dll
    �[1;32mStackTrace : �[0m
   at System.Management.Automation.Runspaces.InitialSessionState.Bind_LoadAssemblies(ExecutionContext context)
   at System.Management.Automation.Runspaces.InitialSessionState.Bind(ExecutionContext context, Boolean updateOnly, PSModuleInfo module, Boolean noClobber, Boolean local, Boolean setLocation)
   at Microsoft.PowerShell.Commands.ModuleCmdletBase.LoadModuleManifest(String moduleManifestPath, ExternalScriptInfo manifestScriptInfo, Hashtable data, Hashtable localizedData, ManifestProcessingFlags manifestProcessingFlags, Version minimumVersion, Version maximumVersion, Version requiredVersion, Nullable`1 requiredModuleGuid, ImportModuleOptions& options, Boolean& containedErrors)
    �[1;32mSource     : �[0mSystem.Management.Automation
    �[1;32mHResult    : �[0m-2146232799
�[1;32mCategoryInfo          : �[0mInvalidOperation: (:) [Import-Module], FileLoadException
�[1;32mFullyQualifiedErrorId : �[0mFormatXmlUpdateException,Microsoft.PowerShell.Commands.ImportModuleCommand
�[1;32mInvocationInfo        : �[0m
    �[1;32mMyCommand        : �[0mImport-Module
    �[1;32mScriptLineNumber : �[0m1
    �[1;32mOffsetInLine     : �[0m1
    �[1;32mHistoryId        : �[0m20
    �[1;32mLine             : �[0mipmo az.resources
    �[1;32mPositionMessage  : �[0mAt line:1 char:1
                       + ipmo az.resources
                       + ~~~~~~~~~~~~~~~~~
    �[1;32mInvocationName   : �[0mipmo
    �[1;32mCommandOrigin    : �[0mInternal
�[1;32mScriptStackTrace      : �[0mat <ScriptBlock>, <No file>: line 1

[rjmholt]

@bgelens are you able to drill into the error? Like $error[0].Exception.InnerException | fl -f * type of thing? If there's an indicator of what assembly isn't loading that would help.

@PrzemyslawKlys raised that there might be an issue with the layout of that VSIX, so it might be an issue with how I built it.

[bgelens]

There is no InnerException 🤷‍♂ I removed the vsix installed version and moved back to 2019.11.0 preview and I have the same issue.

Switching to non-preview and the import is successful. I'll see if I can find some more info

[rjmholt]

moved back to 2019.11.0 preview and I have the same issue.

Hmmm ok that's definitely a problem. What does the lowest level error look like under fl * -f?

[bgelens]

Removing these from Az.Resources Manifest RequiredAssemblies allows for the import

'.\Microsoft.Extensions.Caching.Abstractions.dll', 
'.\Microsoft.Extensions.Caching.Memory.dll', 
'.\Microsoft.Extensions.DependencyInjection.Abstractions.dll', 
'.\Microsoft.Extensions.Options.dll', 
'.\Microsoft.Extensions.Primitives.dll', 

Still trying to pinpoint the exact dll's.. I removed 1 by 1 already but that didn't work so it's a combination

[rjmholt]

Looks like it's Primitives + DI.Abstractions -- the Omnisharp LSP library depends on them.

We'll need to investigate a workaround for the dependency hell issue. We've already discussed pushing the LSP work into another thread or process in a different issue, but that was also deemed to be too breaking due to argument completers and static class bits not working.

[bgelens]

I've pinpointed to these 2:

• Microsoft.Extensions.DependencyInjection.Abstractions.dll
• Microsoft.Extensions.Options.dll

Leaving in Primitives will not block the import

I need to move off preview as I'm working with the Az modules every day. LMK if I can assist in debugging / previewing fixes

[rjmholt]

Just discussed this with @daxian-dbw. It's a hard problem to solve, but we think we might be able to fix it in this case:

• Move O# and its dependencies out of the same dir as PSES.dll
• Create a fresh assembly load context and load O# into it
• We add an assembly load event at the earliest possible point when PSES starts up (before it pulls in O#) so that when PSES goes to load O# we redirect to the custom asm load context

[rjmholt]

Ok this is a bit more complicated because of needing to support multiple .NET runtimes.

Playing with it a bit I think we need:

• A new assembly that provides a binary entrypoint for Start-EditorServices (dovetails nicely with turning Start-EditorServices into a binary module).
• In Windows PowerShell this loads EditorServices into a new AppDomain
• In PowerShell 7 this loads EditorServices into a new AssemblyLoadContext
• In PowerShell 6 there's nothing we can do unfortunately (but PowerShell 7 will be what you want anyway)

[daxian-dbw]

@rjmholt I suggest you to look into Assembly.LoadFile. An assembly loaded by Assembly.LoadFile is always loaded in to a separate load context, both on .NET and .NET Core.

In PowerShell 6 there's nothing we can do unfortunately (but PowerShell 7 will be what you want anyway)

Could you please explain why is that?