Not able to step through script after the latest update to VSCode

[westerdaled]

Issue Description

I work a lot with PowerShell in VSCode and it generally very stable. Today I upgraded VSCode to the latest release and this seems to have broken the PowerShell Preview Extension IMHO
e.g. both "Step Over" & "Step Into" disabled No highlighting of current line. Help, I am back to using the ISE 😫
PowerShell extension log.txt

Attached Logs

Follow the instructions in the README about
capturing and sending logs.

Environment Information

Visual Studio Code

Name	Version
Operating System	Windows_NT x64 10.0.18362
VSCode	1.37.1
PowerShell Extension Version	2019.5.0

PowerShell Information

Name	Value
PSVersion	5.1.18362.145
PSEdition	Desktop
PSCompatibleVersions	1.0 2.0 3.0 4.0 5.0 5.1.18362.145
BuildVersion	10.0.18362.145
CLRVersion	4.0.30319.42000
WSManStackVersion	3.0
PSRemotingProtocolVersion	2.3
SerializationVersion	1.1.0.1

Visual Studio Code Extensions

Visual Studio Code Extensions(Click to Expand)

Extension	Author	Version
azure-account	ms-vscode	0.8.4
bracket-pair-colorizer	CoenraadS	1.0.61
code-spell-checker	streetsidesoftware	1.7.18
csharp	ms-vscode	1.21.0
debugger-for-chrome	msjsdiag	4.11.7
githistory	donjayamanne	0.4.6
gitlens	eamodio	9.9.3
markdown-all-in-one	yzhang	2.4.2
markdown-shortcuts	mdickin	0.11.0
powershell-preview	ms-vscode	2019.5.0
python	ms-python	2019.8.30787
quicktype	quicktype	12.0.46
rest-client	humao	0.22.0
shell-launcher	Tyriar	0.3.0
team	ms-vsts	1.149.2
tslint	eg2	1.0.44
vscode-apache	mrmlnc	1.2.0
vscode-azurefunctions	ms-azuretools	0.18.0
vscode-browser-preview	auchenberg	0.5.9
vscode-docker	ms-azuretools	0.7.0
vscode-edit-csv	janisdd	0.1.2
vscode-guid	heaths	1.4.15
vscode-icons	vscode-icons-team	9.2.0
vscode-spfx-deploy-package	RencoreGmbH	1.1.0

[SydneyhSmith]

@westerdaled sorry to hear that you are hitting crashes, and thanks for opening this issue and providing this info/logs---It would be really helpful if you could also attach diagnostic logging--instructions for how to do that are here

[rjmholt]

@westerdaled are there other indications the extension is working? Do you get completions? Does the Integrated Console work?

[westerdaled]

@rjmholt Yes the syntax completion works. Indeed most things but not the debugger
.
I could debug this successfully in the IDE but in VSCode I never even see a breakpoint reached. very weird!

[westerdaled]

@SydneyhSmith
Diagnostic level now set ( despite what is indicated in the logs).
vscode-powershell.log

[SydneyhSmith]

@westerdaled thanks for providing that log...the one that would be most helpful in that folder is the EditorServices file (the whole folder is the best option)...if you could also provide a GIF or screenshots of the completions you are getting that would be awesome! Thanks!

[westerdaled]

@SydneyhSmith , I actually witnessed the debugger work today after starting the VScode in my project directory ( normally, I just start "Code" from the Windows 10 Start) . However, this was short lived so still have an issue. Looks to me that debugger just hangs after it gets used .
issue2144_logs.zip

[SydneyhSmith]

@westerdaled thanks for providing the GIF and logs, it would also be super helpful to know the debug configuration you have and any other PowerShell-related settings you have in VSCode

[rjmholt]

This seems to be the method experiencing an NRE, but it's not clear why and our logging (unusually) doesn't have a stack trace.

Reading through that method, there aren't any obvious places where an NRE would occur that I can see, so that implies that something has gone bad before that method is called.

You might be able to capture this NRE happening with procdump by running the extension, finding its process ID (easiest way is with $PID in the integrated terminal), from cmd running procdump -e 1 -f "NullReferenceException $PID. That will create a dump when that NRE occurs, which you can send to us at vscode-powershell@microsoft.com (the dump will be large, so you'll probably need to upload it somewhere and send a link).

It looks like we should also improve the logging on the debug adapter here. We're currently overhauling the extension, so some of that might come for free when we get to the debug adapter.

[westerdaled]

@SydneyhSmith

{
    "window.zoomLevel": 0,
    "terminal.integrated.shell.windows": "C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\powershell.exe",
    "powershell.developer.featureFlags": [ "PSReadLine" ],
    "git.autofetch": true,
    "markdown.extension.preview.autoShowPreviewToSide": true,
    "team.showWelcomeMessage": false,
    "workbench.colorTheme": "Monokai",
    "workbench.iconTheme": "vscode-icons",
    "vsicons.dontShowNewVersionMessage": true,
    "azureFunctions.enableSlots": true,
    "azureFunctions.projectLanguage": "PowerShell",
    "terminal.integrated.rendererType": "dom",
    "powershell.powerShellExePath": "C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\powershell.exe",
    "editor.fontSize": 12,
    "powershell.developer.editorServicesLogLevel": "Diagnostic"
}

My profile settings are

if ($env:TERM_PROGRAM -eq "vscode") {
    Set-PSReadLineKeyHandler -Chord 'Ctrl+w' -Function BackwardKillWord
    Set-PSReadLineKeyHandler -Chord 'Alt+D' -Function KillWord
    Set-PSReadLineKeyHandler -Chord 'Ctrl+@' -Function MenuComplete    
}