No option to restart session in some instances

[PrzemyslawKlys]

Issue Description

There are times that PowerShell session will crash. Normally you can restart it but there are instances where it won't allow you too.

The status in the bottom:

Most likely it happens when you are told that session crashed, it asks you if you want to restart it, you respond no, and there is no option to "start" it again.

Expected Behaviour

Ability to restart the session, always.

[TylerLeonhardt]

Ctrl + Shift + P -> "PowerShell Restart Session" or something similar is what you want to use.

[PrzemyslawKlys]

Right, but that's how it normally looks like:

I'm just reporting this for consistency reasons. I can use workarounds, keybindings but still, GUI fix would be cool? ;-)

[TylerLeonhardt]

Oh interesting. I see so it doesn't show Restart Current Session when you click on "Session Exited" at the bottom. Yeah that seems like a bug.

Of course... It shouldn't crash... But that's a different story.

[PrzemyslawKlys]

I noticed it crashes a lot if you delete a file outside of session and recreate it, especially if a recreated file has errors in it. I'm currently playing with dynamic .psd1/.psm1 building and I have those files open and during the process, the file is deleted, and then recrreated and further modified outside of VSCode. It would very often crash if something was wrong with it (for example a wrong amount of , or so. But my guess is that it suddenly loses track of what the file had in comparison to what it has now.

[rjmholt]

Looks like the logic for this is here:

vscode-powershell/src/session.ts

Lines 738 to 765 in 2a282b1

	if (this.sessionStatus === SessionStatus.Running) {
	const currentPowerShellExe =
	availablePowerShellExes
	.find((item) => item.exePath.toLowerCase() === currentExePath);
	const powerShellSessionName =
	currentPowerShellExe ?
	currentPowerShellExe.versionName :
	`PowerShell ${this.versionDetails.displayVersion} ` +
	`(${this.versionDetails.architecture}) ${this.versionDetails.edition} Edition ` +
	`[${this.versionDetails.version}]`;
	menuItems = [
	new SessionMenuItem(
	`Current session: ${powerShellSessionName}`,
	() => { vscode.commands.executeCommand("PowerShell.ShowLogs"); }),
	new SessionMenuItem(
	"Restart Current Session",
	() => { this.restartSession(); }),
	];
	} else if (this.sessionStatus === SessionStatus.Failed) {
	menuItems = [
	new SessionMenuItem(
	`Session initialization failed, click here to show PowerShell extension logs`,
	() => { vscode.commands.executeCommand("PowerShell.ShowLogs"); }),
	];
	}

If it's a valid thing to do, perhaps we should just always add the restart option?

[rjmholt]

Ok we think the powershellItems concat line should be under if (status == SessionStatus.Running) and the restart option should be at the bottom, outside the if statement.

[PrzemyslawKlys]

Thanks! :-)