Code provider folding is not folding here strings

[rkeithhill]

System Details

• Operating system name and version: Windows 10 1803
• VS Code version: 1.25.0 32-bit
• PowerShell extension version: daily build with PR (GH-1413) Resolve promise correctly in Folding feature #1416 pulled down
• Output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      5.1.17134.137
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17134.137
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

Code folding via the folding provider seems to be working for everything except here strings:

FWIW the npm tests fail on my dev machine:

Attached Logs

7/9/2018 9:13:36 PM [NORMAL] - Visual Studio Code v1.25.0 32-bit
7/9/2018 9:13:36 PM [NORMAL] - PowerShell Extension v1.7.0
7/9/2018 9:13:36 PM [NORMAL] - Operating System: Windows 64-bit
7/9/2018 9:13:36 PM [DIAGNOSTIC] - Succesfully required c:\Program Files (x86)\Microsoft VS Code\resources\app/node_modules.asar/vscode-textmate
7/9/2018 9:13:36 PM [DIAGNOSTIC] - Loaded the vscode-textmate module
7/9/2018 9:13:36 PM [DIAGNOSTIC] - Created the textmate Registry
7/9/2018 9:13:36 PM [DIAGNOSTIC] - PowerShell grammar file specified as c:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\powershell\syntaxes\powershell.tmLanguage.json
7/9/2018 9:13:36 PM [NORMAL] - Language server starting --
7/9/2018 9:13:36 PM [NORMAL] -     exe: C:\WINDOWS\Sysnative\WindowsPowerShell\v1.0\powershell.exe
7/9/2018 9:13:36 PM [NORMAL] -     args: C:\Users\Keith\GitHub\rkeithhill\PowerShellEditorServices\module\PowerShellEditorServices\Start-EditorServices.ps1 -HostName 'Visual Studio Code Host' -HostProfileId 'Microsoft.VSCode' -HostVersion '1.7.0'-AdditionalModules @('PowerShellEditorServices.VSCode') -BundledModulesPath 'C:\Users\Keith\GitHub\rkeithhill\PowerShellEditorServices\module'-EnableConsoleRepl -LanguageServicePipeName LanguageService_55b445f8a3da0175246c.pipe -DebugServicePipeName DebugService_55b445f8a3da0175246c.pipe -LogLevel 'Diagnostic' -LogPath 'C:\Users\Keith\GitHub\rkeithhill\vscode-powershell\logs\1531192416-someValue.sessionId\EditorServices.log' -SessionDetailsPath 'C:\Users\Keith\GitHub\rkeithhill\vscode-powershell\sessions\PSES-VSCode-21924-436123' -FeatureFlags @()
7/9/2018 9:13:36 PM [NORMAL] - Syntax Folding Provider registered
7/9/2018 9:13:37 PM [NORMAL] - powershell.exe started, pid: 29196
7/9/2018 9:13:41 PM [NORMAL] - Language server started.
7/9/2018 9:13:41 PM [NORMAL] - {"status":"started","debugServiceTransport":"NamedPipe","languageServiceTransport":"NamedPipe","debugServicePipeName":"DebugService_55b445f8a3da0175246c.pipe","languageServicePipeName":"LanguageService_55b445f8a3da0175246c.pipe"}
7/9/2018 9:13:41 PM [NORMAL] - Connecting to language service on pipe LanguageService_55b445f8a3da0175246c.pipe...
7/9/2018 9:13:41 PM [NORMAL] - Language service connected.

[rkeithhill]

Ping @glennsarti

[glennsarti]

Hrmmm...can't repro on my own machine ...

[rkeithhill]

Could it be something to do with me running 32-bit VSCode? That'd be odd but not unheard of. Are you looking at this file via the extension debug host?

[glennsarti]

yes and I'm running 32bit too.

[glennsarti]

What's the green squiggle saying underneath your $I

[rkeithhill]

That the variable $I is never used. Do you have code analysis disabled?

[glennsarti]

So the test failure is on that particular piece of text. The plot thickens... AND I can repro that failure.

[glennsarti]

Oh that's super weird. The tokenizer didn't see the heredoc.

[rjmholt]

Yeah I wondered if it was a grammar problem...

[rjmholt]

In that case, we should open an issue in EditorSyntax and mark as Resolution-External

[glennsarti]

Nope...not so fast. I can repro the test failure, but not the actual failure.

[glennsarti]

Currently thinking this is a test fixture issue and it's loading the wrong powershell grammar file...

[rkeithhill]

I noticed when the VSCode instance pops up during the test, it is v1.24.1. Even though I have v1.25 installed.

[glennsarti]

@rkeithhill Can you please try changing the file from CRLF to LF to see if it makes a difference

[rkeithhill]

Hmm, that fixes it. So, uh, that's weird.