This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Add enforcement of TLS1.2 #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmeister
reviewed
Jun 8, 2020
| @@ -90,6 +90,10 @@ function Find-Module { | |||
| ) | |||
|
|
|||
| Begin { | |||
| # Change security protocol to TLS 1.2 | |||
| $script:securityProtocol = [Net.ServicePointManager]::SecurityProtocol | |||
| [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 | |||
There was a problem hiding this comment.
I don't think it is a good idea @alerickson to hard-code the usage of just one protocol. If the Gallery wants to enforce Tls13 in the future, then that change would brick all versions of PowerShellGet where the protocol is hard-coded like that and one would not even be able to change it on a higher level. cc @SteveL-MSFT
Rather, I suggest to add the Tls12 security protocol as follows, which is the standard, recommended practice:
[Net.ServicePointManager]::SecurityProtocol = [Net.ServicePointManager]::SecurityProtocol -bor [Net.SecurityProtocolType]::Tls12
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the PowerShell Gallery needing to enforce TLS 1.2, we've had a number of complaints from those still using lower versions. Additions in this PR will save the user's current security protocol settings, then change the security protocol to TLS 1.2 in order to send requests via the updated version, then revert the security protocol back to the user's setting before the request was sent.