Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Removes PSGallery availability checks #374

Merged
merged 11 commits into from
Nov 27, 2018
Merged

Removes PSGallery availability checks #374

merged 11 commits into from
Nov 27, 2018

Conversation

OCram85
Copy link
Contributor

@OCram85 OCram85 commented Nov 26, 2018

📦 Changes

  • removes Get-PSGalleryApiAvailability references and the function itself
  • removes Check-PSGalleryApiAvailability references and the function itself
  • removes unused variables
  • Removes Pester test cases for
    • Get-PSGalleryApiAvailability
    • Check-PSGalleryApiAvailability

📔 General Changes

  • Introduced vscode workspace settings to enable common style

🔖 Ref

@msftclas
Copy link

msftclas commented Nov 26, 2018

CLA assistant check
All CLA requirements met.

@edyoung
Copy link
Contributor

edyoung commented Nov 26, 2018

Mi Marco, thanks for the PR. I don't see a problem, and expect to merge it once we have fixed the CI tests, which are currently failing for an unrelated reason. For future reference, in general I find it easier to review if a functional change is not 'mixed in' with reformatting the affected files, because it's trickier to spot the actual changes among all the style updates.

@alerickson
Copy link
Member

@OCram85 there's a missing } that should be on line 204 of PSGetModuleSource.Tests.ps1 (closing out the describe block on line 87), but everything else looks good

@OCram85
Copy link
Contributor Author

OCram85 commented Nov 27, 2018

@alerickson: Thanks for the help :D - I've just updated the PR.

@edyoung: I'm not sure if I messed with the common style in this project. I personally like adding defaults with vscode workspace settings. If needed - I would also split this PR and introduce the defaults with a separate PR which also would include fixing the style issues in all files ^^

@OCram85 OCram85 changed the title [WIP] Remove PSGallery availability checks Removes PSGallery availability checks Nov 27, 2018
@alerickson alerickson merged commit 6fc51a5 into PowerShell:development Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check-PSGalleryApiAvailability prevents working with PSGallery
5 participants