Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Use TestDrive in Pester.PSGetModuleHelp.Tests.ps1 #370

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Use TestDrive in Pester.PSGetModuleHelp.Tests.ps1 #370

merged 1 commit into from
Nov 27, 2018

Conversation

matt9ucci
Copy link
Contributor

As written in the PowerShell's testing guideline, it is preferred to use Pester's TestDrive to custom temp dir.

@edyoung
Copy link
Contributor

edyoung commented Nov 21, 2018

This change looks fine - thanks! But we have some other failing tests which are causing CI build to fail. Will merge this once that is resolved.

BTW It would not be quite as straightforward to use TestDrive: for all of the places where PowerShellGet uses temp files, because the package provider code runs in a separate runspace created by package management module, and that code can't access the testdrive variable.

@alerickson alerickson merged commit b722b35 into PowerShell:development Nov 27, 2018
@matt9ucci matt9ucci deleted the patch-TestDrive branch November 27, 2018 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants