Update-ModuleManifest prepends 'PSGet_' to the module name on line 2

[ThePoShWolf]

On an existing module manifest line 2 may look like this:

# Module manifest for module 'ModuleName'

After running Update-ModuleManifest , line two will appear like this:

# Module manifest for module 'PSGet_ModuleName

This appears to be a result of prepending 'PSGet_' to the module manifest in $tempPath on line 677.

Steps to reproduce

New-ModuleManifest .\Test.psd1
Update-ModuleManifest .\Test.psd1

Expected behavior

Line 2:
# Module manifest for module 'Test'

Actual behavior

Line 2:
# Module manifest for module 'PSGet_Test'

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.17134.407
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17134.407
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

> Get-Module -ListAvailable PowerShellGet,PackageManagement
ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     1.2.4      PackageManagement                   {Find-Package, Get-Package, Get-PackageProvider, Get-PackageSource...}
Script     1.2.2      PackageManagement                   {Find-Package, Get-Package, Get-PackageProvider, Get-PackageSource...}
Binary     1.0.0.1    PackageManagement                   {Find-Package, Get-Package, Get-PackageProvider, Get-PackageSource...}
Script     2.0.4      PowerShellGet                       {Find-Command, Find-DSCResource, Find-Module, Find-RoleCapability...}
Script     1.0.0.1    PowerShellGet                       {Install-Module, Find-Module, Save-Module, Update-Module...}

> Get-PackageProvider -ListAvailable
Name                     Version          DynamicOptions
----                     -------          --------------
msi                      3.0.0.0          AdditionalArguments
msu                      3.0.0.0
nuget                    2.8.5.208
NuGet                    3.0.0.1          Destination, ExcludeVersion, Scope, SkipDependencies, Headers, FilterOnTag, Contains, AllowPrereleaseVersions, ConfigFile, SkipValidate
PowerShellGet            2.0.4.0          PackageManagementProvider, Type, Scope, AllowClobber, SkipPublisherCheck, InstallUpdate, NoPathUpdate, AllowPrereleaseVersions, Filter, Tag, Includes, DscResource, RoleCapability, Command, Ac...
PowerShellGet            1.0.0.1
Programs                 3.0.0.0          IncludeWindowsInstaller, IncludeSystemComponent

[SydneyhSmith]

@ThePoShWolf Thanks for posting--I am able to easily reproduce this issue. It looks like this issue may be happening here:
https://github.com/PowerShell/PowerShellGet/blob/eb60d92976683c467732d041d8966341db8aa501/src/PowerShellGet/public/psgetfunctions/Update-ModuleManifest.ps1#L677

[ThePoShWolf]

Indeed! I wasn't sure how to link a line, otherwise I would have on the initial submit. I'll remember that for next time!

I'm also assuming that the temporary file needs to have a different name from the original and it needs to keep the .psd1 extension to keep New-ModuleManifest happy (so no module.psd1.tmp). Because of that, I'm not sure the best way to fix it.

Maybe doing a regex replace on line 2 of the manifest after it has been updated? I dunno.

[SydneyhSmith]

That seems correct, feel free to try and tackle this issue if you want!

[ThePoShWolf]

Sure! I'll take it. I should have some time tomorrow. How do I go about getting it assigned to me? I have not contributed to PowerShellGet before.

[ThePoShWolf]

That'll do! Thanks @SydneyhSmith !