Cherry pick PR 1750 to legacy/1.x branch, fix more issues #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encode more chars like %, &, ' , etc
|
Note - this PR will need to be merged back to |
There was a problem hiding this comment.
looking good. @rkeithhill are you planning on doing the porting to the master branch or would you like me to do it?
src/PowerShellEditorServices.Host/CodeLens/PesterCodeLensProvider.cs
Outdated
Show resolved
Hide resolved
Closed
|
It doesn't matter too much one way or the other to me. Let me know what you'd prefer. |
|
I think this PR is good to go. Definintely want to get this in for 1.12. |
SeeminglyScience
approved these changes
Mar 19, 2019
Co-Authored-By: rkeithhill <r_keith_hill@hotmail.com>
|
I've cherry-picked most of the changes... this has put your PR in a bad state, unfortunately :( |
TylerLeonhardt
approved these changes
Mar 20, 2019
|
I will squash this. since it has additional changes on top. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've worked around the compilation issue by replacing
HttpUtility.EncodePath()withUri.EscapeDataPath(). The latter API is a much closer match to the RFC 3986 spec that VSCode uses.Also fixed another bug in the ReferenceCodeLensProvider where it was not properly creating a DocumentUri based on my abusive file name of
foo's_~#-[@] +,;=%.ps1. That filename now works when using the symbol ref code lens.