(maint) Add Xunit Trait Filter #818
Conversation
PowerShellEditorServices.build.ps1
Outdated
| function XunitTraitFilter { | ||
| $TraitFilter = '' | ||
| # Reference https://docs.microsoft.com/en-us/dotnet/core/testing/selective-unit-tests | ||
| if (![string]::IsNullOrEmpty($TestFilter)) { $TraitFilter = "-trait $TestFilter" } |
There was a problem hiding this comment.
Since $TestFilter is type string, it is sufficient to use the more canonical if (!$TestFilter) { ... }
There was a problem hiding this comment.
Actually this whole function could be simplified to just:
if ($TestFilter) { "-train $TestFilter" } else { "" }
There was a problem hiding this comment.
if (!$TestFilter)
{
return ""
}
"-train $TestFilter"There was a problem hiding this comment.
I can change it but I'm not really a fan of that kind of operation. It makes things like if ("False") { Write-Out "This is True" } confusing. I prefer explicit checks
There was a problem hiding this comment.
if ($TestFilter) is still an explicit check of "is string null or empty" and sorry but "False" is not null or empty. I mean, underneath PS is just doing string.IsNullOrEmpty for you.
There was a problem hiding this comment.
Also, in the vein of please follow the coding style that already exists in the script, you will see this style:
if (-not $name)
...
if ($env:APPVEYOR) {
There was a problem hiding this comment.
My feeling is that it's a common convention in Python, JS and PowerShell for a reason. It can be abused, but this case is precisely the design intent. Same as return value || default.
In PowerShell's case, calling the C# APIs is sometimes less robust; PowerShell's coercions absorb more possible bad cases with less code.
Previously when running tests all test would need to be run, however when this can take a while. This commit adds an option to add a trait filter to XUnit as per the Xunit documentation [1]. Later commits may add the actual trait attributes to the tests. [1] https://docs.microsoft.com/en-us/dotnet/core/testing/selective-unit-tests
glennsarti
force-pushed
the
make-testing-configurable
branch
from
574dcb6 to
4764566
Compare
Previously when running tests all tests would need to be run, however when developing this
can take a while. This commit adds an option to add a trait filter to XUnit
as per the Xunit documentation [1]. Later commits may add the actual trait
attributes to the tests.
[1] https://docs.microsoft.com/en-us/dotnet/core/testing/selective-unit-tests