Upgrade language server protocol to v3.2.0 #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 19, 2017 19:48
Whenever EditorServices fails to start up, ServerTestsBase.LaunchService goes into a while loop where it reads from the error stream line by line in an async manner, till the end of the stream. This causes the method to wait indefinitely in certain situations. Hence, we replace it with ReadToEndAsync method and time out on the task if it takes too long. This avoids the test cases from hanging at that point.
|
Looks like I missed some types. I think this PR should be ready tomorrow. |
added 13 commits
April 29, 2017 14:35
kapilmb
changed the title
|
This PR is finally ready to be reviewed! |
|
Excellent work man, thanks a lot! I just tried out this PR and the VS Code one on my machine, works great! |
|
Thanks @daviwil ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.