Adopt new language server protocol based on JSON RPC #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reorganizes the files in the Transport.Stdio library to prepare for a split in message structure between language server and debug adapter messages. The following commits will change class hierarchy and namespaces for all affected files.
This change renames the namespaces of all types in the Transport.Stdio assembly to reflect the new type organization. It also changes the default namespace to Microsoft.PowerShell.EditorServices.Protocol. The assembly file name will change in a future commit.
|
Hi @daviwil, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
This change is a major refactoring of the JSON message pipeline that lives in PowerShellEditorServices.Transport.Stdio. A new language server protocol has been introduced which uses the JSON RPC message format. Previously oth the language server and debug adapter messages used the V8 message protocol but this change has brought the need for a modular message pipeline that can support multiple protocols. All message types have been completely redesigned and message handling functionality for all features has been moved into the PowerShellEditorServices.Host project.
This change renames the PoweShellEditorServices.Transport.Stdio project to PowerShellEditorServices.Protocol. This change is in preparation for an eventual move of this library out of this project and into a more general package for VS Code language server and debug adapter authors.
daviwil
force-pushed
the
daviwil/new-protocol
branch
from
82827d9 to
f4cb951
Compare
daviwil
added a commit
that referenced
this pull request
Nov 17, 2015
Adopt new language server protocol based on JSON RPC
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
fixed learn link in marketplace PowerShell#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a major refactoring of the JSON message pipeline that
lives in PowerShellEditorServices.Transport.Stdio. A new language server
protocol has been introduced which uses the JSON RPC message format.
Previously oth the language server and debug adapter messages used the V8
message protocol but this change has brought the need for a modular
message pipeline that can support multiple protocols.
All message types have been completely redesigned and message handling
functionality for all features has been moved into the
PowerShellEditorServices.Host project.