Skip to content

Introduce new editor extensibility API #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2016
Merged

Introduce new editor extensibility API #214

merged 3 commits into from
May 10, 2016

Conversation

daviwil
Copy link
Contributor

@daviwil daviwil commented May 3, 2016

This change introduces a new PowerShell-based API that allows scripts and
modules to extend the behavior of the host editor. Scripts can either
automate the editor directly or register commands that can later be
invoked by the user. The ExtensionService provides this behavior for any
PowerShellContext by injecting a new variable '$psEditor' into the
session.

This version of the API is very early and will be expanded upon in future
releases.


This change is Reviewable

@daviwil
Copy link
Contributor Author

daviwil commented May 3, 2016

Still need to clean up the docs I started writing and test once again to make sure everything works in VS Code.

@daviwil daviwil force-pushed the daviwil/extensions branch 2 times, most recently from 4dd9ae3 to 199266f Compare May 3, 2016 04:56
@rkeithhill
Copy link
Contributor

You've been busy. Nice PR!

@daviwil
Copy link
Contributor Author

daviwil commented May 3, 2016

Yeah, I might have bit off more than I could chew for one release but I think it's a solid basis for future work :) I'll get this merged later today and then knock out a couple other issues for 0.6.0.

By the way, according to VS Code's April Iteration Plan they'll be releasing 1.1.0 next Monday. I think I'll line up our release with that so we've got a few extra days for polish. I'll have family visiting this weekend so I'll get everything I can done before EOD Wednesday and then ship on Monday. That sound OK?

@dfinke
Copy link
Contributor

dfinke commented May 3, 2016

If you'd stop gallivanting around Europe, you might be done.

Looking forward to this.

@rkeithhill
Copy link
Contributor

Yup. I still haven't been able to track down that issue with single stepping in the debugger but the workaround is easy-ish - just slow down. :-)

@daviwil
Copy link
Contributor Author

daviwil commented May 3, 2016

@dfinke I took my time just to annoy you ;)

@rkeithhill If it isn't something that gets hit that often I'm fine with fixing it in a later release. I think that we've got some issues with async Task usage in the debug adapter that might be causing some sequencing issues. When I fix all that up this problem might go away.

@dfinke
Copy link
Contributor

dfinke commented May 3, 2016

@daviwil +100 on that front 👍

@daviwil
Copy link
Contributor Author

daviwil commented May 4, 2016

Taking a little extra time on this because I think I might be able to get an actual documentation site generated from the C# XML doc comments :) DocFX is pretty cool!

@daviwil daviwil force-pushed the daviwil/extensions branch from 4911cd8 to e010dc9 Compare May 4, 2016 15:19
daviwil added 2 commits May 10, 2016 10:28
This change introduces a new PowerShell-based API that allows scripts and
modules to extend the behavior of the host editor.  Scripts can either
automate the editor directly or register commands that can later be
invoked by the user.  The ExtensionService provides this behavior for any
PowerShellContext by injecting a new variable '$psEditor' into the
session.

This version of the API is very early and will be expanded upon in future
releases.
This change fixes the LanguageServerTests.ServiceLoadsProfilesOnDemand
test which was broken by recent changes to our setting loading code.  It
removes a potential condition where sending a null string for the Script
Analyzer settings path causes the AnalysisService to be restarted.  This
restart resulted in a load failure which polluted the console output,
causing the expectations for the profile loading test to fail.
@daviwil daviwil force-pushed the daviwil/extensions branch 2 times, most recently from b8c4705 to f19e645 Compare May 10, 2016 17:39
@daviwil daviwil force-pushed the daviwil/extensions branch from f19e645 to 4816885 Compare May 10, 2016 17:54
@daviwil
Copy link
Contributor Author

daviwil commented May 10, 2016

Going to finish the documentation as a separate pull request. Merging this now.

@daviwil daviwil merged commit 3313968 into master May 10, 2016
@daviwil daviwil deleted the daviwil/extensions branch April 26, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants