Finish PowerShell v3 and v4 support #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change finishes our PowerShell v3 and v4 support by conditionally changing behavior for those versions. This works by using an interface facade in front of any version-specific behavior so that the CLR doesn't try to resolve method names that aren't available in a particular version. Resolves #73.
This change removes a newline that was being written to the debug console when the user steps through code in the debugger. This newline was added for the case where the debug prompt is written at each stop but was not removed when this feature was temporarily taken out. The newline will be reinstated once we have an option for turning on the debugger prompt.
|
What do you think about the name of One cool thing, Keith's conditional and command breakpoint support works in PowerShell v3 and v4 :) |
|
@daviwil Looks good to me! I think the interface name is fine. Very clear what it is doing. 👍 Awesome that the new breakpoint types still work!! |
I was hoping that would be the case. :-) |
daviwil
added a commit
that referenced
this pull request
Mar 9, 2016
Finish PowerShell v3 and v4 support
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change finishes our PowerShell v3 and v4 support by conditionally
changing behavior for those versions. This works by using an interface
facade in front of any version-specific behavior so that the CLR doesn't
try to resolve method names that aren't available in a particular version.