Fix #153: Script Analyzer is not returning markers #161
+48
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue in 0.4.1 where Script Analyzer analysis markers are not being returned by the AnalysisService. This issue was caused by a new optional parameter to the ScriptAnalyzer.Initialize method called 'includeDefaultRules' which was introduced in 1.3.0. Since this parameter has a default value of 'false', the default Script Analyzer rules were not being loaded or applied in analysis runs.
daviwil
force-pushed
the
daviwil/script-analyzer-fix
branch
from
c98a95f to
b792896
Compare
daviwil
added a commit
that referenced
this pull request
Feb 16, 2016
Fix #153: Script Analyzer is not returning markers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue in 0.4.1 where Script Analyzer analysis markers
are not being returned by the AnalysisService. This issue was caused by a
new optional parameter to the ScriptAnalyzer.Initialize method called
'includeDefaultRules' which was introduced in 1.3.0. Since this parameter
has a default value of 'false', the default Script Analyzer rules were not
being loaded or applied in analysis runs.