Fix #159: LanguageServer.Shutdown hangs on flush #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change fixes an issue in the LanguageServer's Shutdown method where buffered output in the OutputDebouncer gets flushed before shutting down. The problem here is the Wait call which blocks the message dispatcher thread from completing the OutputDebouncer.OnFlush method's SendEvent call. The fix is to change the Shutdown method to async so that the Flush call can be awaited, unblocking the message dispatcher thread's SynchronizationContext for the SendEvent call to complete.
daviwil
force-pushed
the
daviwil/shutdown-hang-fix
branch
from
3228c57 to
171afa2
Compare
daviwil
added a commit
that referenced
this pull request
Feb 16, 2016
Fix #159: LanguageServer.Shutdown hangs on flush
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change fixes an issue in the LanguageServer's Shutdown method where
buffered output in the OutputDebouncer gets flushed before shutting down.
The problem here is the Wait call which blocks the message dispatcher
thread from completing the OutputDebouncer.OnFlush method's SendEvent
call. The fix is to change the Shutdown method to async so that the
OnFlush call can be awaited, unblocking the message dispatcher thread's
SynchronizationContext for the SendEvent call to complete.