Fix #157: Tests using OutputReader sometimes hang #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix handles an edge case when buffered output that ends with a newline is treated incorrectly causing an extra empty line to be returend by the OutputReader.
daviwil
force-pushed
the
daviwil/output-reader-fix
branch
from
b012db3 to
9c622d4
Compare
|
Tests pass - that's a good sign. :-) |
|
Sweet! Thanks for the assist. Going to merge it. |
daviwil
added a commit
that referenced
this pull request
Feb 15, 2016
Fix #157: Tests using OutputReader sometimes hang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix handles an edge case when buffered output that ends with a
newline is treated incorrectly causing an extra empty line to be returend
by the OutputReader.