Easier launching of the debugging when /waitForDebugger passed in. #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OK been doing a lot of debugging of the debug adapater and this has been driving me crazy. Launch VSCode, open PS1 file so I can find the PID of the editor host. Then debug the script, hop over to VS attach to process, find the PID of the second host process (the debug instance) and attach. This new approach will just pop up a dialog box asking which instance of VS to use to debug. You can press NO to skip attaching the debugger and the script will continue to execute.
|
This can be merged independent of the script path spaces fix for #149. |
|
This is great, I like it! Don't know why I didn't think of that before ;) If this ends up being a smoother process going forward maybe we can rename the argument to something like |
|
Also, feel free to merge this if you're ready. |
rkeithhill
added a commit
that referenced
this pull request
Feb 10, 2016
…f-dbghost Easier launching of the debugging when /waitForDebugger passed in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK been doing a lot of debugging of the debug adapater and this has been driving me crazy. Launch VSCode, open PS1 file so I can find the PID of the editor host. Then debug the script, hop over to VS attach to process, find the PID of the second host process (the debug instance) and attach. This new approach will just pop up a dialog box asking which instance of VS to use to debug. You can press NO to skip attaching the debugger and the script will continue to execute.