Skip to content

Bump Newtonsoft.Json from 12.0.2 to 13.0.1 #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 29, 2021

Bumps Newtonsoft.Json from 12.0.2 to 13.0.1.

Release notes

Sourced from Newtonsoft.Json's releases.

13.0.1

  • New feature - Add JsonSelectSettings with configuration for a regex timeout
  • Change - Remove portable assemblies from NuGet package
  • Change - JsonReader and JsonSerializer MaxDepth defaults to 64
  • Fix - Fixed throwing missing member error on ignored fields
  • Fix - Fixed various nullable annotations
  • Fix - Fixed annotations not being copied when tokens are cloned
  • Fix - Fixed naming strategy not being used when deserializing dictionary enum keys
  • Fix - Fixed serializing nullable struct dictionaries
  • Fix - Fixed JsonWriter.WriteToken to allow null with string token
  • Fix - Fixed missing error when deserializing JToken with a contract type mismatch
  • Fix - Fixed JTokenWriter when writing comment to an object

12.0.3

  • New feature - Added support for nullable reference types
  • New feature - Added KebabCaseNamingStrategy
  • Change - Package now uses embedded package icon
  • Fix - Fixed bug when merging JToken with itself
  • Fix - Fixed performance of calling ICustomTypeDescriptor.GetProperties
  • Fix - Fixed serializing Enumerable.Empty and empty arrays on .NET Core 3.0
  • Fix - Fixed deserializing some collection types with constructor
  • Fix - Fixed deserializing IImmutableSet to ImmutableHashSet instead of ImmutableSortedSet
  • Fix - Fixed deserializing IImmutableDictionary to ImmutableDictionary instead of ImmutableSortedDictionary
  • Fix - Fixed deserializing into constructors with more than 256 parameters
  • Fix - Fixed hang when deserializing JTokenReader with preceding comment
  • Fix - Fixed JSONPath scanning with nested indexer
  • Fix - Fixed deserializing incomplete JSON object to JObject
  • Fix - Fixed using StringEnumConverter with naming strategy and specified values
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 29, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/nuget/Newtonsoft.Json-13.0.1 branch April 29, 2021 23:09
@andyleejordan
Copy link
Member

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 20, 2021

Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use @dependabot reopen if the branch has been deleted).

@andyleejordan
Copy link
Member

@dependabot reopen

@dependabot dependabot bot reopened this Jul 20, 2021
@dependabot dependabot bot restored the dependabot/nuget/Newtonsoft.Json-13.0.1 branch July 20, 2021 00:18
@andyleejordan
Copy link
Member

@rjmholt I had the bot reopen and rebase this because upon inspection, OmniSharp is using 11.x and we're already on 12.x, so the argument of staying at OmniSharp's version is invalid. We should either downgrade to 11.x or upgrade to 13.x if it causes no problems.

Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 12.0.2 to 13.0.1.
- [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases)
- [Commits](JamesNK/Newtonsoft.Json@12.0.2...13.0.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/Newtonsoft.Json-13.0.1 branch from 89b6a61 to d1a338e Compare July 20, 2021 00:27
@rjmholt
Copy link
Contributor

rjmholt commented Jul 20, 2021

Our issue here is needing to be compatible with the oldest version of Newtonsoft.Json shipped in a PowerShell we support, which I think is going to be in 7.0

@andyleejordan
Copy link
Member

Ah, that's good to know!

@andyleejordan
Copy link
Member

andyleejordan commented Jul 21, 2021

Ok, some documentation: PowerShell 7.0.0 uses Newtonsoft.Json 12.0.3.

The upcoming release PowerShell 7.2.0 release uses Newtonsoft.Json 13.0.1.

So we'll ignore this until such time that we ever drop 7.0.0 support or reconsider this coupling.

@andyleejordan
Copy link
Member

@dependabot ignore this major version

@dependabot dependabot bot closed this Jul 21, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 21, 2021

OK, I won't notify you about version 13.x.x again, unless you re-open this PR or update to a 13.x.x release yourself.

@dependabot dependabot bot deleted the dependabot/nuget/Newtonsoft.Json-13.0.1 branch July 21, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants