-
Notifications
You must be signed in to change notification settings - Fork 237
Type completion with tooltips #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TylerLeonhardt
merged 20 commits into
PowerShell:master
from
AspenForester:TypeCompletion
Sep 9, 2020
Merged
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4fc43f0
Should improve type completion
hc-jb-lewis c3ca4c0
New Class for type name completion test
hc-jb-lewis 5135778
New test for type name completion
hc-jb-lewis 3621114
type name completion example
hc-jb-lewis b780ecc
semicolons and barce mismatches
hc-jb-lewis c686152
Case sensitivity
hc-jb-lewis b4879be
methods are case sensitive, too!
hc-jb-lewis b50fc95
dots count!
hc-jb-lewis 9a6e1b9
better test example
hc-jb-lewis 481c4c1
added more characters. Test still not passing
hc-jb-lewis 0caf978
Tyler's suggestions for the test criteria (it works for him)
hc-jb-lewis f47ae9d
the whole type name
TylerLeonhardt 84b4f67
Completing Namespace completions
hc-jb-lewis 4d1ee82
make 25 15 for namespace
TylerLeonhardt afa88fa
try this with the namespace test
TylerLeonhardt dfc4c8f
rev line number
TylerLeonhardt 9801156
Don't use GetTypeInfo()
TylerLeonhardt 3fd2a06
skip on windows powershell
TylerLeonhardt 0ad0843
add skippable fact
TylerLeonhardt d5ac379
add versionutils
TylerLeonhardt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
test/PowerShellEditorServices.Test.Shared/Completion/CompleteTypeName.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
// | ||
// Copyright (c) Microsoft. All rights reserved. | ||
// Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
// | ||
|
||
using Microsoft.PowerShell.EditorServices.Services.TextDocument; | ||
|
||
namespace Microsoft.PowerShell.EditorServices.Test.Shared.Completion | ||
{ | ||
internal class CompleteTypeName | ||
{ | ||
public static readonly ScriptRegion SourceDetails = | ||
new ScriptRegion( | ||
file: TestUtilities.NormalizePath("Completion/CompletionExamples.psm1"), | ||
text: string.Empty, | ||
startLineNumber: 21, | ||
startColumnNumber: 25, | ||
startOffset: 0, | ||
endLineNumber: 0, | ||
endColumnNumber: 0, | ||
endOffset: 0); | ||
|
||
public static readonly CompletionDetails ExpectedCompletion = | ||
CompletionDetails.Create( | ||
"ArrayList", | ||
CompletionType.Type, | ||
"System.Collections.ArrayList" | ||
); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,3 +17,5 @@ function Test-Completion { | |
} | ||
|
||
Get-ChildItem / | ||
|
||
[System.Collections.ArrayList].GetType() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.