Fix when no CommandInfo comes back #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
Apr 29, 2020
| @@ -96,7 +96,7 @@ internal static class CommandHelpers | |||
| .FirstOrDefault(); | |||
|
|
|||
| // Only cache CmdletInfos since they're exposed in binaries they are likely to not change throughout the session. | |||
| if (commandInfo.CommandType == CommandTypes.Cmdlet) | |||
| if (commandInfo?.CommandType == CommandTypes.Cmdlet) | |||
There was a problem hiding this comment.
It would have crashed here before this change if commandInfo was null. Now that the code will get past here, do the callers of this method properly handle a null return value?
There was a problem hiding this comment.
Yes. They handle a null value. The change I added with the caching is what didn't handle a null value
rjmholt
approved these changes
Apr 29, 2020
rkeithhill
approved these changes
Apr 29, 2020
SeeminglyScience
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PSES drops an exception in the log. It's "handled" so the extension doesn't break down... but we don't want the stacktrace in the log.
The behavior is still the same, this just prevents when
Get-Commandreturns nothing.