Skip to content

Startup task tweaks #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 26, 2020
Merged

Startup task tweaks #1203

merged 7 commits into from
Feb 26, 2020

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Feb 24, 2020

  • Makes disposal logic simpler
  • Passes tasks through rather than awaiting them internally
  • Fixes a bug where the logger was catching the wrong exception type
  • Always kick the PSES start logic onto a new thread

TylerLeonhardt
TylerLeonhardt approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SeeminglyScience
SeeminglyScience approved these changes Feb 25, 2020
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt rjmholt merged commit 00a4d2a into PowerShell:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjmholt @TylerLeonhardt @SeeminglyScience