Skip to content

AnalysisService improvments #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Feb 14, 2020
Merged

AnalysisService improvments #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
2710077
Fix AnalysisService initialization
Feb 5, 2020
104da3f
Remove old analysis service
Feb 5, 2020
617ba31
Restore old runspace pool settings
Feb 5, 2020
ba36e45
Change analysis engine throwing to null analysis engine
Feb 5, 2020
d3d22a9
Add some comments
Feb 5, 2020
ccb4caa
Allow AnalysisService to reinstantiate its engine
Feb 5, 2020
660e895
Move more functionality behind AnalysisService
Feb 6, 2020
e3dee1a
Move help API into AnalysisService
Feb 6, 2020
0a488c2
Add comments
rjmholt Feb 6, 2020
0b10f9a
Simplify design and add more comments
rjmholt Feb 6, 2020
03fdc3c
Fix logger instantiation
rjmholt Feb 6, 2020
da2491c
Undo new switch syntax
rjmholt Feb 6, 2020
5154ed7
Fix code action out-of-order issue
rjmholt Feb 6, 2020
062ca75
Fix codeAction issue
rjmholt Feb 7, 2020
983b3bb
Add comment about URI fix
rjmholt Feb 7, 2020
c9edb7a
Remove null diagnostics from test
rjmholt Feb 7, 2020
62fd954
Remove unused imports
rjmholt Feb 7, 2020
a0d006c
Explicitly get PssaCmdletAnalysisEngine to implement IDisposable
rjmholt Feb 7, 2020
92d79b7
Add ConfigureAwait(false)
rjmholt Feb 7, 2020
7c0cee5
Remove commented out code
rjmholt Feb 7, 2020
a4e65ad
Better event invocation
rjmholt Feb 7, 2020
5d6cf78
Change codeaction dict to use scriptfiles
Feb 11, 2020
2aed0a6
Address @TylerLeonhardt's comments
Feb 11, 2020
47c8b0b
Ensure PSModulePath is preserved when looking for PSSA
Feb 13, 2020
81267d1
Remove unused method
Feb 13, 2020
393bd59
Remove unneeded using
Feb 13, 2020
da558b4
Add comment explaining correction table entry class
Feb 13, 2020
7dd68e2
Enhance PSSA ISS comment
Feb 13, 2020
23dbbe3
Address issues
Feb 14, 2020
de071f9
Remove cleverness with PSSA runspace management
Feb 14, 2020
2d7fd1d
Remove unused constant
Feb 14, 2020
c9b2a4c
Remove unused region
Feb 14, 2020
e3dbcd4
Change using order
Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/PowerShellEditorServices/Server/PsesServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,7 @@ public static IServiceCollection AddPsesLanguageServices(
.Wait();
return extensionService;
})
.AddSingleton<AnalysisService>(
(provider) =>
{
return AnalysisService.Create(
provider.GetService<ConfigurationService>(),
provider.GetService<OmniSharp.Extensions.LanguageServer.Protocol.Server.ILanguageServer>(),
provider.GetService<ILoggerFactory>().CreateLogger<AnalysisService>());
});
.AddSingleton<AnalysisService>();
}

public static IServiceCollection AddPsesDebugServices(
Expand Down
1,001 changes: 252 additions & 749 deletions src/PowerShellEditorServices/Services/Analysis/AnalysisService.cs
View file
Open in desktop

Large diffs are not rendered by default.

Loading