Skip to content

add ADOPTERS.md #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2019
Merged

add ADOPTERS.md #1120

merged 2 commits into from
Dec 5, 2019

Conversation

SteveL-MSFT
Copy link
Member

Create ADOPTERS.md allowing contributors to add themselves

@SteveL-MSFT SteveL-MSFT assigned rjmholt and unassigned TylerLeonhardt Dec 3, 2019
@TylerLeonhardt
Copy link
Member

@SteveL-MSFT
Copy link
Member Author

@TylerLeonhardt the intent is for the adopters to submit the PR with their own language, not for us to fill it out

@TylerLeonhardt
Copy link
Member

I see so does this file light up some GitHub graph magic or something or is this something we're starting?

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT
Copy link
Member Author

@TylerLeonhardt I'm not aware of any GitHub integration. This is a common file used in other OSS projects.

@TylerLeonhardt
Copy link
Member

@SteveL-MSFT so should we reach out to our partners and say "hey can you add yourself to this list?"

@TylerLeonhardt
Copy link
Member

cc @SydneyhSmith

@SteveL-MSFT
Copy link
Member Author

@TylerLeonhardt yes, once this is merged

@TylerLeonhardt
Copy link
Member

@SteveL-MSFT should vscode-powershell have one of these as well?

@SteveL-MSFT
Copy link
Member Author

@TylerLeonhardt wouldn't that just be a subset of PSES?

@TylerLeonhardt
Copy link
Member

I guess so... But PSES is an implementation detail for like... vscode and Azure Data Studio.

Then there's like... The Azure Functions extension that depends on the PowerShell extension for debugging.

@SteveL-MSFT
Copy link
Member Author

I don't think there's an inherent issue with a separate one for vs-ps extension. It just seemed like that one would be much more limited in adopters.

@TylerLeonhardt TylerLeonhardt merged commit a01792c into PowerShell:master Dec 5, 2019
@SteveL-MSFT SteveL-MSFT deleted the adopters branch December 5, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants