GetEditorContext throws NullReferenceException when not supported

[SeeminglyScience]

$psEditor.GetEditorContext currently throws a AggregateException wrapping a NullReferenceException when not supported by the editor. It should throw a NotSupportedException instead.

In Atom:

$psEditor.GetEditorContext()
# Exception calling "GetEditorContext" with "0" argument(s): "One or more errors occurred."
# At line:1 char:1
# + $psEditor.GetEditorContext()
# + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#     + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
#     + FullyQualifiedErrorId : AggregateException
 
$Error[0].Exception.GetBaseException() | Format-List * -Force
# Message        : Object reference not set to an instance of an object.
# Data           : {}
# InnerException : 
# TargetSite     : Microsoft.PowerShell.EditorServices.Extensions.EditorContext 
#                  ConvertClientEditorContext(Microsoft.PowerShell.EditorServices.Protocol.LanguageServer.ClientEditorContext)
# StackTrace     :    at Microsoft.PowerShell.EditorServices.Protocol.Server.LanguageServerEditorOperations.ConvertClientEditorContext(ClientEditorContext 
#                  clientContext)
#                     at Microsoft.PowerShell.EditorServices.Protocol.Server.LanguageServerEditorOperations.<GetEditorContext>d__3.MoveNext()
# HelpLink       : 
# Source         : Microsoft.PowerShell.EditorServices.Protocol
# HResult        : -2147467261

[TylerLeonhardt]

In Atom

🤓

[SeeminglyScience]

It doesn't anymore 🎉 🎉

(but only because it supports GetEditorContext now, other implementations that don't support it will still throw a NRE)

[TylerLeonhardt]

This is going to be tough to repro then, huh :(

[daviwil]

Nah, just comment out this block of code, run the extension, then type $psEditor.GetEditorContext() in the Integrated Console and you'll see it :)