Skip to content

Update trusted platform assemblies list for latest PowerShell release #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2020
Merged

Update trusted platform assemblies list for latest PowerShell release #56

merged 2 commits into from
Oct 15, 2020

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Oct 14, 2020 •
edited
Loading

Fixes #55

Update the TPA for new dependency

daxian-dbw
daxian-dbw reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you didn't refresh all the list. For example, Markdig.dll doesn't exist in the publish folder, and Markdig.Signed is not included.

src/powershell-native/nativemsh/pwrshcommon/pwrshcommon.cpp Outdated
@@ -769,6 +769,7 @@ namespace NativeMsh
"System.Management.Automation",
"System.Memory",
"System.Net",
"System.Net.Connections"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"System.Net.Connections"
"System.Net.Connections",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@adityapatwardhan adityapatwardhan changed the title Add System.Net.Connections to trusted platform assemblies list Update trusted platform assemblies list for latest PowerShell release Oct 15, 2020
@adityapatwardhan adityapatwardhan merged commit 01de78e into PowerShell:master Oct 15, 2020
@adityapatwardhan adityapatwardhan deleted the UpdateTPA branch October 15, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update the TPA for WS-MAN in the native repo.
2 participants
@adityapatwardhan @daxian-dbw