Fix libpsl-native to build and pass tests on FreeBSD #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After merging PowerShell/PowerShell#7129 we will no longer use src/isfile.cpp. |
|
I am working on a CI system for this repo. We should take this change once that is in place. @mateusrodrigues Thank you for your PR. |
adityapatwardhan
force-pushed
the
libpsl-freebsd
branch
from
5d93d22 to
06c74d4
Compare
|
@mateusrodrigues I have enable CI now and hence rebased your PR. |
adityapatwardhan
requested changes
Oct 3, 2018
| @@ -45,6 +49,22 @@ char* GetUserFromPid(pid_t pid) | |||
|
|
|||
| return GetPwUid(oldp.kp_eproc.e_ucred.cr_uid); | |||
|
|
|||
| #elif defined(__FreeBSD__) | |||
There was a problem hiding this comment.
Instead of this can the following work?
#elif (defined(__APPLE__) && defined(__MACH__)) || defined(__FreeBSD__)There was a problem hiding this comment.
The return statement is the only one that really changes from macOS' implementation. I rewrote the ifdefs to replace only the return section.
|
Is this PR abandoned? |
mateusrodrigues
force-pushed
the
libpsl-freebsd
branch
from
8f74c33 to
4b838af
Compare
adityapatwardhan
approved these changes
Feb 5, 2019
|
@mateusrodrigues Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this PR from PowerShell/#7208 as requested by @adityapatwardhan
The only change necessary after all was in file
getuserfrompid.cpp, sinceisfile.cppis following a PathExists implementation and was correct in the first place as tests were previously fixed.With changes from this PR, all tests are passing on FreeBSD.