-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall much saner looking code then the previous library! LGTM with some optional comments (but please do add newlines in all the files).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than what I've commented, this LGTM as well!
Since you've changed from tabs to spaces, should we have a .vscode folder settings with these common rules? Not sure if everyone who contributes uses this, it won't hurt those who don't and standardise for those who do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't mean to use the "Request changes" option.
Sorry, first time reviewing on GH 🙂
It would be nice to have this as a separate PR. |
Main changes in this:
Clear-GpioResources
; it is needed in very few situations; majority of scenarios do not need to use it.Channel
and addedBusId
andChipSelectLine
parameters (because of specifics of new .NET APIs).TargetFramework
tonetcoreapp3.1
PackageReference
forSystem.Management.Automation
toVersion="7.0.0"
ModuleVersion
to0.2.0
Fix #21
Fix #48
Fix #50
Fix #49