Skip to content
This repository was archived by the owner on Jun 14, 2024. It is now read-only.

Updates for v2 of the module #51

Merged
merged 3 commits into from
Apr 10, 2020
Merged

Conversation

anmenaga
Copy link

@anmenaga anmenaga commented Apr 4, 2020

Main changes in this:

  1. Removed dependency on 3rd party libraries in favor of using .NET Core IoT Libraries.
  2. Updated GPIO and SPI cmdlets with new APIs:
  • because of specifics of new .NET APIs and to keep cmdlets simple - added new GPIO cmdlet Clear-GpioResources; it is needed in very few situations; majority of scenarios do not need to use it.
  • in SPI cmdlets removed Channel and added BusId and ChipSelectLine parameters (because of specifics of new .NET APIs).
  1. To align with PowerShell 7.0 release:
  • updated TargetFramework to netcoreapp3.1
  • updated PackageReference for System.Management.Automation to Version="7.0.0"
  1. Bumped ModuleVersion to 0.2.0
  2. Replaced tabs with spaces in source code
  3. All GPIO, I2C and SPI cmdlets were verified on Raspberry Pi with BME280 and RC522 RFID modules

Fix #21
Fix #48
Fix #50
Fix #49

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall much saner looking code then the previous library! LGTM with some optional comments (but please do add newlines in all the files).

Copy link
Contributor

@DanielSSilva DanielSSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than what I've commented, this LGTM as well!
Since you've changed from tabs to spaces, should we have a .vscode folder settings with these common rules? Not sure if everyone who contributes uses this, it won't hurt those who don't and standardise for those who do

Copy link
Contributor

@DanielSSilva DanielSSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't mean to use the "Request changes" option.
Sorry, first time reviewing on GH 🙂

@anmenaga
Copy link
Author

Since you've changed from tabs to spaces, should we have a .vscode folder settings with these common rules?

It would be nice to have this as a separate PR.

@anmenaga anmenaga merged commit a0b59a0 into PowerShell:master Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants