-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
Hey @jnury, thanks for this! I just want to let you know that we'll need to add the Microsoft copyright comment on top of all the ps*1s. Is that going to be ok with you? Since we don't have too many examples, you can keep your name under the author but that could change later since this is an official Microsoft repo and compliance changes. |
The alternative is that we can turn the Examples ToC README into a list of examples that include links to outside modules. |
Hello Tyler, no problem at all, you can change anything you want ;-) |
And if you prefer to link to another repo, it's OK for me too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @jnury!! Loved this example 😃
Can you just do one thing for me and add an item in the table here that will link to your example:
https://github.com/PowerShell/PowerShell-IoT/blob/master/Examples/README.md
also I had one comment that you can address if you're feeling up to it (not required).
return $Device | ||
} | ||
|
||
function Get-ADXL345Data { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment I won't block on... but I think it'd be good practice to have Get-ADXL345Data
call Get-ADXL345Device
if $Device
was not passed in. It save's just a little bit of typing if they're using the default settings. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉 Thanks for adding this example!
Thank YOU :-) |
This is an example module to interact with ADXL345 accelerometer thru I2C; as shown at PSConf.eu ;-)