Skip to content
This repository was archived by the owner on Jun 14, 2024. It is now read-only.

Adding an ADXL345 example #39

Merged
merged 7 commits into from
May 9, 2018
Merged

Adding an ADXL345 example #39

merged 7 commits into from
May 9, 2018

Conversation

jnury
Copy link
Contributor

@jnury jnury commented May 6, 2018

This is an example module to interact with ADXL345 accelerometer thru I2C; as shown at PSConf.eu ;-)

@TylerLeonhardt
Copy link
Member

Hey @jnury, thanks for this! I just want to let you know that we'll need to add the Microsoft copyright comment on top of all the ps*1s.

Is that going to be ok with you? Since we don't have too many examples, you can keep your name under the author but that could change later since this is an official Microsoft repo and compliance changes.

@TylerLeonhardt
Copy link
Member

The alternative is that we can turn the Examples ToC README into a list of examples that include links to outside modules.

@jnury
Copy link
Contributor Author

jnury commented May 8, 2018

Hello Tyler, no problem at all, you can change anything you want ;-)

@jnury
Copy link
Contributor Author

jnury commented May 8, 2018

And if you prefer to link to another repo, it's OK for me too.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @jnury!! Loved this example 😃

Can you just do one thing for me and add an item in the table here that will link to your example:

https://github.com/PowerShell/PowerShell-IoT/blob/master/Examples/README.md

also I had one comment that you can address if you're feeling up to it (not required).

return $Device
}

function Get-ADXL345Data {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment I won't block on... but I think it'd be good practice to have Get-ADXL345Data call Get-ADXL345Device if $Device was not passed in. It save's just a little bit of typing if they're using the default settings. 😄

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Thanks for adding this example!

@TylerLeonhardt TylerLeonhardt merged commit 22e29ec into PowerShell:master May 9, 2018
@jnury
Copy link
Contributor Author

jnury commented May 9, 2018

Thank YOU :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants