Skip to content

Ensure coverage of all active Windows releases #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2020
Merged

Ensure coverage of all active Windows releases #461

merged 3 commits into from
Jul 23, 2020

Conversation

TBBle
Copy link
Contributor

@TBBle TBBle commented Jul 22, 2020 •
edited
Loading

PR Summary

This adds Windows 2004 releases to all the lists, and Windows 1909 to a
few lists from which it was missing.

This should replace #436, the Dependabot reminder that Windows 2004 is now available.

PR Checklist

@TBBle
Copy link
Contributor Author

TBBle commented Jul 22, 2020

I didn't update createAllManifests.ps1 because it doesn't currently include Windows 1909, and it wasn't obvious if it was intended to include "all" manifests, or the currently-selected list only.

TravisEz13
TravisEz13 reviewed Jul 22, 2020
View reviewed changes
TravisEz13
TravisEz13 reviewed Jul 22, 2020
View reviewed changes
release/preview/nanoserver1809/meta.json Outdated
@@ -15,4 +24,4 @@
"TestProperties": {
"size": 1
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make this posix, and add the newline back.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean by posix here.

TravisEz13
TravisEz13 reviewed Jul 22, 2020
View reviewed changes
TravisEz13
TravisEz13 reviewed Jul 22, 2020
View reviewed changes
TravisEz13
TravisEz13 reviewed Jul 22, 2020
View reviewed changes
TravisEz13
TravisEz13 reviewed Jul 22, 2020
View reviewed changes
TravisEz13
TravisEz13 requested changes Jul 22, 2020
View reviewed changes
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the line-endings are blocking.

@TBBle
Ensure coverage of all active Windows releases
1685613 
This adds Windows 2004 releases to all the lists, and Windows 1909 to a
few lists from which it was missing.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
@RDIL RDIL requested a review from TravisEz13 July 22, 2020 18:13
@TBBle
Copy link
Contributor Author

TBBle commented Jul 22, 2020 •
edited
Loading

Is there a code-formatter config for this repo? All I changed were the numbers, VSCode's 'save all' applied the formatting.

Edit: Seems this is VSCode's not-json formatter non-overridable default. But there is a setting to then add the final newline back. I also tried prettier, but it wanted to change the whitespace even more.

TBBle added 2 commits July 23, 2020 04:20
@TBBle
Move shortTags from getLatestTag.ps1 to meta.json
96ccb39 
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
@TBBle
Update README.powershellcommunity.md location in PR template
debff32 
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
@TBBle
Copy link
Contributor Author

TBBle commented Jul 22, 2020 •
edited by unfurl-links bot
Loading

Hmm. I can't see how the CI failures are related to this, they're all reporting failed connections to https://registry.hub.docker.com/. I don't have permission to trigger retries either.

@RDIL
Copy link
Collaborator

RDIL commented Jul 22, 2020

@PoshChan please retry CI

@PoshChan
Copy link
Collaborator

@RDIL, successfully started retry of docker-PR

@TBBle
Copy link
Contributor Author

TBBle commented Jul 22, 2020

Same problem, in mostly the same jobs, and a few different jobs. The page-numbers in nextUrl are quite high, is it possible the registry is rate-limiting the script? Do we really need to search 47 pages of tags to find the latest tag for a particular repository?

@TravisEz13
Copy link
Member

@TBBle When I looked, AzDevOps failed to connect to the agent. I don't think that is the issue.

We have plans to eliminate the calls to get the tags.

@TravisEz13
Copy link
Member

community failures can be addressed in a separate PR.

@TravisEz13 TravisEz13 merged commit d78d60f into PowerShell:master Jul 23, 2020
@TBBle TBBle deleted the all_active_windows_releases branch July 23, 2020 18:05
@TravisEz13 TravisEz13 mentioned this pull request Jul 30, 2020
Closed
@donny-dont
Copy link

@TravisEz13 apologies that I missed this when opening an issue. Is there anything to watch for 2004 variants being pushed to mcr.microsoft.com/powershell?

@TBBle
Copy link
Contributor Author

TBBle commented Aug 18, 2020 •
edited
Loading

https://mcr.microsoft.com/v2/powershell/tags/list (and https://hub.docker.com/_/microsoft-powershell) shows nanoserver-2004 and windowsservercore-2004 variants for lts (7.0.3) and preview (7.1.0 preview 6) now.

@TravisEz13
Copy link
Member

Yes, the team released yesterday. I was less involved that normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TBBle @RDIL @PoshChan @TravisEz13 @donny-dont