Skip to content

Add Ubuntu 20.04 #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 12, 2020
Merged

Add Ubuntu 20.04 #422

merged 15 commits into from
May 12, 2020

Conversation

TravisEz13
Copy link
Member

PR Summary

Add Ubuntu 20.04

This also starts using our own full tag for that image
cc @RDIL
Requirements for that

  • from tag must be defined in docker file
  • short tags must be in the meta.json
  • tag formats must be in meta.json
  • the script to generate the tags must not exist

PR Checklist

@RDIL
Copy link
Collaborator

RDIL commented May 12, 2020

I don't believe I have write access to this branch

@TravisEz13
Copy link
Member Author

@RDIL I should merged it soon...
I'm just testing it...

@RDIL RDIL self-requested a review May 12, 2020 20:36
@RDIL RDIL self-assigned this May 12, 2020
Co-authored-by: Reece Dunham <me@rdil.rocks>
@TravisEz13
Copy link
Member Author

I made the change in a way to ensure it is not breaking.

@TravisEz13 TravisEz13 marked this pull request as ready for review May 12, 2020 21:13
@TravisEz13 TravisEz13 requested a review from anmenaga as a code owner May 12, 2020 21:13
@@ -11,6 +11,6 @@
"test-deps-debian"
],
"TestProperties": {
"size": 316
"size": 332

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size of what?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The finalized image file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It a test most teams like us do to make sure images don't grow unexpectedly

@TravisEz13 TravisEz13 merged commit 1c0d50b into PowerShell:master May 12, 2020
@TravisEz13 TravisEz13 deleted the Add-20-04 branch May 12, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants