Update node to v14 #419
Merged
Update node to v14 #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
approved these changes
May 4, 2020
|
unfortunately this increased the image sizes... |
Signed-off-by: Reece Dunham <me@rdil.rocks>
Signed-off-by: Reece Dunham <me@rdil.rocks>
|
Actually these aren't supported by azure dev ops... that was our primary scenario... |
|
and I think the depended on node 10... |
|
@TravisEz13 what depends on node 10? |
|
Azure DevOps had a specific node version dependency. |
|
Well how can we test this then because this version of node 10 not only has high severity vulnerabilities but is also about to be EOL'd. |
|
We have to build and delpoy them to test... |
|
Here are the current requirements docs: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/container-phases?view=azure-devops
|
|
let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Reece Dunham me@rdil.rocks
PR Summary
Node 10 goes EOL soon and dependabot keeps bugging everybody about this so I think its time to update.
PR Checklist
Dockerfile,.sh,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.