Add dockerlint

[RDIL]

PR Summary

Adds the dockerlint tool

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Change is not breaking
• Make sure all Dockerfile, .sh, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
• Adds a new image or tag
  • Not Applicable
• OR
  • Update README.powershellcommunity.md
  • Update vsts-ci.yml

and also since we are in the middle of a pandemic, here is something to cheer everyone up

[TravisEz13]

You should use this wrapper to execute native commands: https://github.com/PowerShell/PowerShell/blob/b7c66ab3ef584956a2872856ee8b351784f522d9/build.psm1#L1396

GitHub

PowerShell/PowerShell

PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

[RDIL]

That's only for windows, plus I changed it to just use bash.

[TravisEz13]

You should really create a python package. Put it in the GitHub python package registry: https://github.com/features/packages

Then do the rest of the steps on the CI machine.

GitHub

GitHub Packages: Your packages, at home with their code

With GitHub Packages you can safely publish and consume packages within your organization or with the entire world.

[RDIL]

All the CI machine is doing right now is downloading and decompressing the executable...

plus it already a python package that I'm building into an executable. I suppose I could setup the CI to clone the repo or something but I feel like that wouldn't be an efficient way to do it

[TravisEz13]

But building it to a native on the other machine, causes the wrong libc to be needed.

[RDIL]

Fair enough, should be fixed now

[RDIL]

@TravisEz13 good news: its working. Bad news: it isn't working on windows so does azure devops have an environment variable for if it is on windows so I can skip

[RDIL]

@TravisEz13 see https://dev.azure.com/powershell/docker/_build/results?buildId=51668&view=logs&j=59760ad3-d83c-5873-e7bc-29164ae56e48&t=a3ff8f5a-08da-5f2f-269f-a49fac996a03&l=21 for example failure

[RDIL]

Fyi @TravisEz13 here is example output for the script:

/bin/bash --noprofile --norc /home/vsts/work/_temp/529d60fd-1be4-4387-b296-097b95f45f9e.sh

    Starting dockerlint...

info: Using dockerfile from path: release/stable/debian9/docker/Dockerfile
issue: line 20 - uses apt install without no-install-recommends lacks-no-install-recommends
issue: line 33 - uses apt install without no-install-recommends lacks-no-install-recommends

Meaning that issue lines follow the format of:
issue: line [NUMBER] - [DESCRIPTION] [PROBLEM-ID]

[TravisEz13]

Would be nice if it showed up as a test, but this is fine.

[TravisEz13]

but we can't commit it broken...

[RDIL]

Yeah, I was going to fix it later today. What test result format does it need to output for it to show up in azure devops?

[TravisEz13]

https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/test/publish-test-results?view=azure-devops&tabs=yaml

JUnit, NUnit, VSTest, xUnit, cTest

One of those

[RDIL]

Alright, I'll implement reporting through JUnit-compatible XML data.

[RDIL]

@PoshChan please rerun CI

[PoshChan]

@RDIL, successfully started rebuild of docker-PR

[TravisEz13]

test results look good

[TravisEz13]

thanks

[RDIL]

Alright, merging the junit feature into master, then will fix the issues here.

[TravisEz13]

Thanks for your contribution

[RDIL]

@TravisEz13 do you have any suggestions for checks I should add?

[TravisEz13]

Not right now, in the future, we want the from tags to be static (not a varible)