-
Notifications
You must be signed in to change notification settings - Fork 155
Add POWERSHELL_DISTRIBUTION_CHANNEL environment variable #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TravisEz13
merged 10 commits into
PowerShell:master
from
adityapatwardhan:AddDistChannel
Aug 8, 2019
Merged
Add POWERSHELL_DISTRIBUTION_CHANNEL environment variable #256
TravisEz13
merged 10 commits into
PowerShell:master
from
adityapatwardhan:AddDistChannel
Aug 8, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDIL
reviewed
Aug 2, 2019
RDIL
approved these changes
Aug 2, 2019
b116f19
to
0369e5e
Compare
TravisEz13
requested changes
Aug 5, 2019
@@ -9,12 +9,16 @@ ARG PACKAGE_VERSION=6.2.0_preview.2 | |||
ARG PS_PACKAGE=powershell-preview-${PACKAGE_VERSION}-1.rhel.7.x86_64.rpm | |||
ARG PS_PACKAGE_URL=https://github.com/PowerShell/PowerShell/releases/download/v${PS_VERSION}/${PS_PACKAGE} | |||
|
|||
ARG fromTag=7 | |||
ARG imageRepo=centos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imageRepo is unused
0b85385
to
93e72fc
Compare
TravisEz13
reviewed
Aug 8, 2019
@TravisEz13 can you update your review? |
TravisEz13
approved these changes
Aug 8, 2019
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add POWERSHELL_DISTRIBUTION_CHANNEL environment variable to all images.
PR Checklist
Dockerfile
,.sh
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.