Skip to content

Add POWERSHELL_DISTRIBUTION_CHANNEL environment variable #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 8, 2019

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Aug 1, 2019

PR Summary

Add POWERSHELL_DISTRIBUTION_CHANNEL environment variable to all images.

PR Checklist

@@ -9,12 +9,16 @@ ARG PACKAGE_VERSION=6.2.0_preview.2
ARG PS_PACKAGE=powershell-preview-${PACKAGE_VERSION}-1.rhel.7.x86_64.rpm
ARG PS_PACKAGE_URL=https://github.com/PowerShell/PowerShell/releases/download/v${PS_VERSION}/${PS_PACKAGE}

ARG fromTag=7
ARG imageRepo=centos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imageRepo is unused

@ghost ghost added the Waiting on Author label Aug 5, 2019
@ghost ghost removed the Waiting on Author label Aug 5, 2019
@adityapatwardhan
Copy link
Member Author

@TravisEz13 can you update your review?

@TravisEz13 TravisEz13 merged commit 8da8107 into PowerShell:master Aug 8, 2019
@ghost
Copy link

ghost commented Aug 12, 2019

🎉20190812 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants