Skip to content

Bump fedora from 28 to 30 in /release/preview/fedora28/dependabot #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 26 additions & 18 deletions build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ End {
$dupeTagIssues = @()

$toBuild = @()
$builtSubImages = @()
foreach ($actualChannel in $Channels) {
if ($PSCmdlet.ParameterSetName -match '.*ByName')
{
Expand Down Expand Up @@ -263,25 +264,32 @@ End {
foreach ($tagGroup in $allMeta.ActualTagDataByGroup.Keys)
{
$actualTagData = $allMeta.ActualTagDataByGroup.$tagGroup
Write-Verbose -Message "getting subimage - fromtag: $($tagGroup.Name) - subimage: $($allMeta.Meta.SubImage)"
$SubImagePath = Join-Path -Path $dockerFileName -ChildPath $allMeta.Meta.SubImage

$subImageAllMeta = Get-DockerImageMetaDataWrapper `
-DockerFileName $SubImagePath `
-CI:$CI.IsPresent `
-IncludeKnownIssues:$IncludeKnownIssues.IsPresent `
-ChannelPath $channelPath `
-TagFilter $TagFilter `
-Version $windowsVersion `
-ImageName $ImageName `
-LinuxVersion $linuxVersion `
-TagData $allMeta.TagData `
-BaseImage $actualTagData.ActualTags[0] `
-BaseRepositry $Repository `
-Strict:$CheckForDuplicateTags.IsPresent


$toBuild += $subImageAllMeta
if($builtSubImages -notcontains $SubImagePath)
{
Write-Verbose -Message "getting subimage - fromtag: $($tagGroup.Name) - subimage: $($allMeta.Meta.SubImage)"
$subImageAllMeta = Get-DockerImageMetaDataWrapper `
-DockerFileName $SubImagePath `
-CI:$CI.IsPresent `
-IncludeKnownIssues:$IncludeKnownIssues.IsPresent `
-ChannelPath $channelPath `
-TagFilter $TagFilter `
-Version $windowsVersion `
-ImageName $ImageName `
-LinuxVersion $linuxVersion `
-TagData $allMeta.TagData `
-BaseImage $actualTagData.ActualTags[0] `
-BaseRepositry $Repository `
-Strict:$CheckForDuplicateTags.IsPresent


$toBuild += $subImageAllMeta
$builtSubImages += $SubImagePath
}
else
{
Write-Verbose -Message "already got subimage - fromtag: $($tagGroup.Name) - subimage: $($allMeta.Meta.SubImage)"
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@

# Dummy docker image to trigger dependabot PRs

FROM fedora:28
FROM fedora:30
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
# return objects representing the tags we need to base the fedora image on

# The versions of fedora we care about
$shortTags = @('28')
$shortTags = @('28','29','30')

$parent = Join-Path -Path $PSScriptRoot -ChildPath '..'
$repoRoot = Join-Path -path (Join-Path -Path $parent -ChildPath '..') -ChildPath '..'
$modulePath = Join-Path -Path $repoRoot -ChildPath 'tools\getDockerTags'
Import-Module $modulePath

Get-DockerTags -ShortTags $shortTags -Image "fedora" -FullTagFilter '^28$' -OnlyShortTags
Get-DockerTags -ShortTags $shortTags -Image "fedora" -FullTagFilter '^\d{2}$' -OnlyShortTags
File renamed without changes.
2 changes: 1 addition & 1 deletion release/servicing/opensuse423/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

# Define arg(s) needed for the From statement
ARG fromTag=42.3
ARG imageRepo=opensuse
ARG imageRepo=opensuse/leap

FROM ${imageRepo}:${fromTag} AS installer-env

Expand Down
2 changes: 1 addition & 1 deletion release/servicing/opensuse423/getLatestTag.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ $repoRoot = Join-Path -path (Join-Path -Path $parent -ChildPath '..') -ChildPath
$modulePath = Join-Path -Path $repoRoot -ChildPath 'tools\getDockerTags'
Import-Module $modulePath

Get-DockerTags -ShortTags $shortTags -Image "opensuse" -FullTagFilter '^42.3$' -OnlyShortTags
Get-DockerTags -ShortTags $shortTags -Image "opensuse/leap" -FullTagFilter '^42\.3$' -OnlyShortTags
5 changes: 4 additions & 1 deletion release/servicing/opensuse423/meta.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,8 @@
"SkipGssNtlmSspTests": true,
"tagTemplates": [
"#psversion#-opensuse-#tag#"
]
],
"TestProperties": {
"size": 524
}
}
2 changes: 1 addition & 1 deletion tools/getDockerTags/getDockerTags.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ function Get-DockerTags

if(!$tags)
{
throw 'no results'
throw 'no results: '+$Image
}

foreach($shortTag in $ShortTags)
Expand Down
8 changes: 8 additions & 0 deletions vsts-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,19 @@ jobs:
name: centos7
imagename: centos7

- template: .vsts-ci/phase.yml
parameters:
name: fedora
imagename: fedora
stable: false
preview: true

- template: .vsts-ci/phase.yml
parameters:
name: fedora28
imagename: fedora28
stable: true
preview: false

- template: .vsts-ci/phase.yml
parameters:
Expand Down