Add code formatting rules #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 20, 2016 19:09
We do not want formatting rules to be run by default whenever scriptanalyzer is invoked. However, the engine doesn't provide a way to disable a given built-in rule without messing with the input parameters or input settings file. Hence we add this parameter to the formatting rules so that they are not run by default whenever scriptanalyer is invoked.
added 10 commits
January 10, 2017 19:31
daviwil
approved these changes
Jan 13, 2017
| @@ -0,0 +1,30 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Copyright headers might be necessary on the new files
| foreach (var settingKey in settings.Keys) | ||
|
|
||
| var settingsKeys = new string[settings.Keys.Count]; | ||
| settings.Keys.CopyTo(settingsKeys, 0); |
There was a problem hiding this comment.
Do settings get removed from the dictionary in the loop?
There was a problem hiding this comment.
Assigning elements to the dictionary while iterating over it was causing problems. After creating a separate copy of the keys the problem went way.
| <value>Place close braces</value> | ||
| </data> | ||
| <data name="PlaceCloseBraceDescription" xml:space="preserve"> | ||
| <value>Place close brace show be on a new line by itself.</value> |
There was a problem hiding this comment.
Should this be "Close brace should be on a new line by itself." ?
|
Looks good! |
|
Thanks @daviwil I just renamed the |
|
Sounds good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following rules
These rules are disabled by default and can enabled only through settings.
Adds an abstract class called
ConfigurableRuleto allow easy configuration of rules from settings.An accompanying settings file (Settings/CodeFormatting.psd1) is provided to run only the formatting rules.
This change is