Add rule severity support for Get-ScriptAnalyzerRule #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Added rule severity to each rule including interfaces 2) Add parameter -Severity to Get-ScriptAnalyzerRule to enable filtering rules based on severity 3) Update Get-ScriptAnalyzerRule format 4) Remove unnessary references from each rule
Modified the column width of "Severity" in Invoke-ScriptAnalyzer output format.
|
BTW, I checked the activities of msftclas, seems like it's an auto-check program designed for validating our license agreement signing. Since we join the MSFT open source group, we are fine ;) |
|
Looks good. Please run all the tests since this change touches a lot of files. |
|
Tests passed for this change. I will open another pull request for test failures due to some other bugs in the rule implementations. |
|
ok. Thanks |
yutingc
added a commit
that referenced
this pull request
Apr 22, 2015
Add rule severity support for Get-ScriptAnalyzerRule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added -Severity parameter in Get-ScriptAnalyzerRule cmdlet. Will filter the rules base on the rule severity specified.
Also updated the output format of Get-ScriptAnalyzerRule and Invoke-ScriptAnalyzer to make them look more aligned.