Add wildcard support when include/exclude rules #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| List<KeyValuePair<CommandInfo, IScriptExtent>> cmdInfoTable = new List<KeyValuePair<CommandInfo, IScriptExtent>>(); | ||
| List<KeyValuePair<CommandInfo, IScriptExtent>> cmdInfoTable = new List<KeyValuePair<CommandInfo, IScriptExtent>>(); | ||
|
|
||
| //Check wild card input for the Include/ExcludRules and create regex match patterns |
|
Can you add tests for the changes? |
|
Thanks Raghu. Corrected typo and added tests of Invoke-ScriptAnalyzer |
| { | ||
| foreach (string rule in includeRule) | ||
| { | ||
| Regex includeRegex = new Regex(rule.Replace("*", ".*?"), RegexOptions.IgnoreCase); |
There was a problem hiding this comment.
Do we want non-greedy matching here? Also I think this may fail if the user input something with special characters (for example, if he/she wants to search something like MyModule.Blah then the dot will be considered as any character).
There was a problem hiding this comment.
I would suggest using this:
Regex reg = new Regex(String.Format("^{0}$", Regex.Escape(rule).Replace(@"*", ".*")))
There was a problem hiding this comment.
Thanks Quoc. I've changed the expression to be non-greedy.
|
rest looks good.. |
Also remove the redundant checking.
|
Looks good to me. |
yutingc
added a commit
that referenced
this pull request
Apr 21, 2015
Add wildcard support when include/exclude rules
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, users can do something like Invoke-ScriptAnalyzer -IncludeRule PSAvoid_, PSUse_
This feature does not apply to customized rules.