Fix false positive for UsingInternalURL #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check if -replace is used and check if invocation expression is [String] or [System.String]
|
Hi Yuting. Does this change address the issue reported by Dan (using composite formatting strings)? -Update- |
|
looks good.. |
| @@ -44,8 +46,19 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName) | |||
| { | |||
| foreach (StringConstantExpressionAst expressionAst in expressionAsts) | |||
| { | |||
| //Check if XPath is used. If XPath is used, then we don't throw warnings. | |||
|
|
|||
| Ast parentAst = expressionAst.Parent; | |||
There was a problem hiding this comment.
Is this gonna raise a NullPointerException if parentAst is null?
There was a problem hiding this comment.
I don't think it will ever be null..At least the root Ast should be a ScriptBlockAst?
There was a problem hiding this comment.
Have you tried on a script with only a string as its content?
There was a problem hiding this comment.
Yeah..I tried with a single line script and it didn't throw warnings or errors.
yutingc
added a commit
that referenced
this pull request
Jun 26, 2015
Fix false positive for UsingInternalURL
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check if -replace is used and check if invocation expression is
[String] or [System.String]. This is to address issue #198