Take BugFixes to Master #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 29, 2015 13:27
…FlowGraph Fix a bug in the flow graphs for throw statements
added 2 commits
May 29, 2015 14:59
…sion does not work for more than one variable
…reThanOneVariable Simplifies logic of suppressing rule and fix a bug where rule suppression does not work for more than one variable
|
The AppVeyor failed because the Rule Suppression tests relies on the suppression of AvoidUninitializedVariable rule on uninitialized parameters but I think this rule no longer applies to parameters in master (got separated into another rule) |
|
Do the failing tests need to be fixed? |
|
So in the Tests\Engine\RuleSuppression.ps1 file, you can change the PSAvoidUninitialiazedVariable suppression to PSProvideDefaultParameterValue. |
|
I will merge the branch and fix any failing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plan on publishing to gallery early next week, so that the rule bug fixes are widely available