Fix AvoidReservedParams does not work if function does not have cmdletbi... #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
People can use reserved parameters on regular functions. This rule should only apply to cmdlets with [cmdletBinding()] |
| @@ -30,43 +30,38 @@ public class AvoidReservedParams : IScriptRule | |||
| public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName) { | |||
| if (ast == null) throw new ArgumentNullException(Strings.NullAstErrorMessage); | |||
|
|
|||
| IEnumerable<Ast> paramAsts = ast.FindAll(testAst => testAst is ParameterAst, true); | |||
| Ast parentAst; | |||
| IEnumerable<Ast> funcAsts = ast.FindAll(item => item is FunctionDefinitionAst, true); | |||
|
|
|||
| string paramName; | |||
|
Update the check for cmdletbinding and initialize the string paramName |
|
Looks good now. Thanks! |
|
looks good.. proceed with the merge. thanks |
quoctruong
pushed a commit
that referenced
this pull request
Apr 10, 2015
Fix AvoidReservedParams does not work if function does not have cmdletbi...
|
Thanks! Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AvoidReservedParams does not work if function does not have cmdlet binding attribute. Also the current implementation looks at the parameter first before the outer function (should be the other way round).