Optimize dsc class interface invocations #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not run the full test pass on my machine. Will wait for appveyor to do this. |
|
Looks good to me. |
raghushantha
added a commit
that referenced
this pull request
May 19, 2015
Optimize dsc class interface invocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a dsc resource, we used to called AnalyzeDSCClass even on non-class based resource.
This fix optimizes the code paths so that we call the class based interface only for resources implemented using classes.
Existing tests already cover testing the invocation of both the interfaces. this change is just a optimization.