Add PSProvideDefaultParameterValue Rule #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per @rkeithhill suggestion in #133
Getting "Object reference not set to an instance of an object error" when running test, but seems to complete successfully. Need to investigate error.
…d inside function
| @@ -65,13 +65,16 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName) | |||
|
|
|||
| HashSet<string> paramVariables = new HashSet<string>(); | |||
|
|
|||
| if (isDscResourceFile && targetResourcesFunctions.Contains(funcAst.Name, StringComparer.OrdinalIgnoreCase)) | |||
| // don't raise the rules for variables in the param block. | |||
| if (funcAst.Body != null && funcAst.Body.ParamBlock != null && funcAst.Body.ParamBlock.Parameters != null) | |||
There was a problem hiding this comment.
If we don't raise this error for param block, I think you can remove the checking for whether this is a DSC resource file.
There was a problem hiding this comment.
Taken care of in 2528ca6
|
Thanks @GoodOlClint for the new rule. Changes look good to me. |
|
Thanks for your contributions GoodOlClint. Your changes are good and the build went well. We will merge the fixes. |
raghushantha
added a commit
that referenced
this pull request
May 18, 2015
Add PSProvideDefaultParameterValue Rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per suggestions in #133 Added new rule for parameters and modified PSAvoidUninitializedVariable rule to ignore variables defined in either the function arguments or a param block.